Remove an ExecutionContextTask subclass in DatabaseTracker

Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=478194
Committed: https://crrev.com/b8d796f8ce8665e7064db8a3ff7b05b45a40c44a
Cr-Commit-Position: refs/heads/master@{#402161}

[hiroshige, 2016-06-26 10:36:39]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-26 10:36:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-06-26 10:50:45]

Description was changed from

==========
Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=
==========

to

==========
Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=478194
==========

[hiroshige, 2016-06-26 10:50:45]

hiroshige@chromium.org changed reviewers:
+ kinuko@chromium.org

[hiroshige, 2016-06-26 10:51:02]

PTAL.

https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp (right):

https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp:188:
(*it)->getDatabaseContext()->getExecutionContext()->postTask(BLINK_FROM_HERE,
createCrossThreadTask(&DatabaseTracker::closeOneDatabaseImmediately,
crossThreadUnretained(this), originString, name, *it));
This CL passes |this| across thread, instead of calling
DatabaseTracker::tracker() in the target thread.
I think this is same and do not modify the behavior (because DatabaseTracker
looks a singleton), but please double check.

[commit-bot: I haz the power, 2016-06-26 11:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-26 11:47:30]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-06-27 01:13:52]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-06-27 01:13:52]

https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp (right):

https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp:188:
(*it)->getDatabaseContext()->getExecutionContext()->postTask(BLINK_FROM_HERE,
createCrossThreadTask(&DatabaseTracker::closeOneDatabaseImmediately,
crossThreadUnretained(this), originString, name, *it));

Why don't you use wrapCrossThreadPersistent?

[hiroshige, 2016-06-27 07:20:06]

https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp (right):

https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp:188:
(*it)->getDatabaseContext()->getExecutionContext()->postTask(BLINK_FROM_HERE,
createCrossThreadTask(&DatabaseTracker::closeOneDatabaseImmediately,
crossThreadUnretained(this), originString, name, *it));
On 2016/06/27 01:13:52, haraken wrote:
> 
> Why don't you use wrapCrossThreadPersistent?

Because DatabaseTracker is not GCed type.

[haraken, 2016-06-27 07:30:25]

On 2016/06/27 07:20:06, hiroshige (slow) wrote:
>
https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
(right):
> 
>
https://codereview.chromium.org/2099093002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp:188:
> (*it)->getDatabaseContext()->getExecutionContext()->postTask(BLINK_FROM_HERE,
> createCrossThreadTask(&DatabaseTracker::closeOneDatabaseImmediately,
> crossThreadUnretained(this), originString, name, *it));
> On 2016/06/27 01:13:52, haraken wrote:
> > 
> > Why don't you use wrapCrossThreadPersistent?
> 
> Because DatabaseTracker is not GCed type.

ah, thanks. LGTM

[kinuko, 2016-06-27 11:10:45]

lgtm

[hiroshige, 2016-06-27 11:14:54]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-06-27 11:14:55]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-06-27 11:15:06]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:15:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 13:45:51]

Description was changed from

==========
Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=478194
==========

to

==========
Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=478194
==========

[commit-bot: I haz the power, 2016-06-27 13:45:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 13:47:18]

Description was changed from

==========
Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=478194
==========

to

==========
Remove an ExecutionContextTask subclass in DatabaseTracker

BUG=478194

Committed: https://crrev.com/b8d796f8ce8665e7064db8a3ff7b05b45a40c44a
Cr-Commit-Position: refs/heads/master@{#402161}
==========

[commit-bot: I haz the power, 2016-06-27 13:47:19]

Patchset 1 (id:??) landed as
https://crrev.com/b8d796f8ce8665e7064db8a3ff7b05b45a40c44a
Cr-Commit-Position: refs/heads/master@{#402161}