Issue 20987007: [telemetry] Fix a defect of javascript in benchmark octane.

Issue 20987007: [telemetry] Fix a defect of javascript in benchmark octane. (Closed)

Created:
7 years, 4 months ago by chrisgao (Use stgao instead)

Modified:
7 years, 4 months ago

Reviewers:
nduca, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Fix a defect of javascript in benchmark octane. BUG=none TEST=tools/perf/run_measurement octane NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214651

Patch Set 3 : reupload #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tools/perf/benchmarks/octane.py	View		1 chunk	+3 lines, -2 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py File tools/perf/benchmarks/octane.py (right): https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py#newcode28 tools/perf/benchmarks/octane.py:28: } Wow, how did this ever work before?

7 years, 4 months ago (2013-07-30 17:30:50 UTC) #2

nduca

> https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py#newcode28 > tools/perf/benchmarks/octane.py:28: } > Wow, how did this ever work before? Seriously. LGTM!

7 years, 4 months ago (2013-07-30 17:40:31 UTC) #3

chrisgao (Use stgao instead)

https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py File tools/perf/benchmarks/octane.py (right): https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py#newcode28 tools/perf/benchmarks/octane.py:28: } On 2013/07/30 17:30:50, tonyg wrote: > Wow, how ...

7 years, 4 months ago (2013-07-30 17:47:09 UTC) #4

tonyg

On 2013/07/30 17:47:09, chrisgao wrote: > https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py > File tools/perf/benchmarks/octane.py (right): > > https://codereview.chromium.org/20987007/diff/11001/tools/perf/benchmarks/octane.py#newcode28 > ...

7 years, 4 months ago (2013-07-30 17:49:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/20987007/11001

7 years, 4 months ago (2013-07-30 21:05:51 UTC) #6

Message was sent while issue was closed.

Change committed as 214651

Expand Messages | Collapse Messages