Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 20987007: [telemetry] Fix a defect of javascript in benchmark octane. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reupload Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/octane.py
diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py
index 1c6fad366df0a2d069f0eee1cb20b829e741023e..9558a8431e933737f414a7ecac19620ec6473f6c 100644
--- a/tools/perf/benchmarks/octane.py
+++ b/tools/perf/benchmarks/octane.py
@@ -19,12 +19,13 @@ completed && !document.getElementById("progress-bar-container")"""
util.WaitFor(_IsDone, 300, poll_interval=5)
js_get_results = """
-var results = {}
+var results = {};
var result_divs = document.querySelectorAll('.p-result');
for (var r in result_divs) {
- if (result_divs[r].id && result_divs[r].id.indexOf('Result-') == 0)
+ if (result_divs[r].id && result_divs[r].id.indexOf('Result-') == 0) {
var key = result_divs[r].id.replace('Result-', '');
results[key] = result_divs[r].innerHTML;
+ }
tonyg 2013/07/30 17:30:50 Wow, how did this ever work before?
chrisgao (Use stgao instead) 2013/07/30 17:47:09 Surprisingly, it seems V8 doesn't complain with th
}
var main_banner = document.getElementById("main-banner").innerHTML;
var octane_score = main_banner.substr(main_banner.lastIndexOf(':') + 2);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698