Source/core/rendering/RenderFlowThread.h - Issue 209863003: [New Multicolumn] balancer confused by content with top margins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlowThread.h

Issue 209863003: [New Multicolumn] balancer confused by content with top margins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test failures in debug mode. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFlowThread.h

diff --git a/Source/core/rendering/RenderFlowThread.h b/Source/core/rendering/RenderFlowThread.h

index 385520a45908cc4f4721d99dbc9f716792b84534..594b6e4438e3b4fd0a19157e042c1b933ea63fb8 100644

--- a/Source/core/rendering/RenderFlowThread.h

+++ b/Source/core/rendering/RenderFlowThread.h

@@ -118,6 +118,7 @@ public:

virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; }

void applyBreakAfterContent(LayoutUnit);

+ virtual bool isPageLogicalHeightKnown() const { return true; }

bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }

void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect);

« no previous file with comments | « Source/core/rendering/RenderBlockFlow.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.h » ('j') | no next file with comments »