Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Side by Side Diff: Source/core/rendering/RenderFlowThread.h

Issue 209863003: [New Multicolumn] balancer confused by content with top margins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test failures in debug mode. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 bool previousRegionCountChanged() const { return m_previousRegionCount != m_ regionList.size(); } 112 bool previousRegionCountChanged() const { return m_previousRegionCount != m_ regionList.size(); }
113 void updatePreviousRegionCount() { m_previousRegionCount = m_regionList.size (); } 113 void updatePreviousRegionCount() { m_previousRegionCount = m_regionList.size (); }
114 114
115 void setRegionRangeForBox(const RenderBox*, LayoutUnit offsetFromLogicalTopO fFirstPage); 115 void setRegionRangeForBox(const RenderBox*, LayoutUnit offsetFromLogicalTopO fFirstPage);
116 void getRegionRangeForBox(const RenderBox*, RenderRegion*& startRegion, Rend erRegion*& endRegion) const; 116 void getRegionRangeForBox(const RenderBox*, RenderRegion*& startRegion, Rend erRegion*& endRegion) const;
117 117
118 virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; } 118 virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) { return false; }
119 void applyBreakAfterContent(LayoutUnit); 119 void applyBreakAfterContent(LayoutUnit);
120 120
121 virtual bool isPageLogicalHeightKnown() const { return true; }
121 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; } 122 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }
122 123
123 void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingB ox, const LayoutRect& dirtyRect); 124 void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingB ox, const LayoutRect& dirtyRect);
124 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox); 125 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox);
125 126
126 void pushFlowThreadLayoutState(const RenderObject&); 127 void pushFlowThreadLayoutState(const RenderObject&);
127 void popFlowThreadLayoutState(); 128 void popFlowThreadLayoutState();
128 LayoutUnit offsetFromLogicalTopOfFirstRegion(const RenderBlock*) const; 129 LayoutUnit offsetFromLogicalTopOfFirstRegion(const RenderBlock*) const;
129 130
130 // Used to estimate the maximum height of the flow thread. 131 // Used to estimate the maximum height of the flow thread.
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 }; 242 };
242 243
243 template <> struct ValueToString<RenderRegion*> { 244 template <> struct ValueToString<RenderRegion*> {
244 static String string(const RenderRegion* value) { return String::format("%p" , value); } 245 static String string(const RenderRegion* value) { return String::format("%p" , value); }
245 }; 246 };
246 #endif 247 #endif
247 248
248 } // namespace WebCore 249 } // namespace WebCore
249 250
250 #endif // RenderFlowThread_h 251 #endif // RenderFlowThread_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlockFlow.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698