Source/core/rendering/RenderMultiColumnFlowThread.h - Issue 209863003: [New Multicolumn] balancer confused by content with top margins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnFlowThread.h

Issue 209863003: [New Multicolumn] balancer confused by content with top margins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test failures in debug mode. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderMultiColumnFlowThread.h

diff --git a/Source/core/rendering/RenderMultiColumnFlowThread.h b/Source/core/rendering/RenderMultiColumnFlowThread.h

index 6687de791962b7db6b537dfaf7e86641ca6971fd..1a350f8ccb82e0e6cdfa7042e1bae8a671f19dae 100644

--- a/Source/core/rendering/RenderMultiColumnFlowThread.h

+++ b/Source/core/rendering/RenderMultiColumnFlowThread.h

@@ -58,6 +58,7 @@ private:

virtual void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) OVERRIDE;

virtual void updateMinimumPageHeight(LayoutUnit offset, LayoutUnit minHeight) OVERRIDE;

virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) OVERRIDE;

+ virtual bool isPageLogicalHeightKnown() const OVERRIDE;

unsigned m_columnCount; // The used value of column-count

LayoutUnit m_columnWidth; // The used value of column-width

« no previous file with comments | « Source/core/rendering/RenderFlowThread.h ('k') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('j') | no next file with comments »