net/quic/core/crypto/crypto_utils_test.cc - Issue 2097913002: Update QuicConnectionLogger to always log missing_packets, even for v34.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/core/crypto/crypto_utils_test.cc

Issue 2097913002: Update QuicConnectionLogger to always log missing_packets, even for v34. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test for domain names containing '_', in order to be more accepting of non-standard SNI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/core/crypto/crypto_utils_test.cc

diff --git a/net/quic/core/crypto/crypto_utils_test.cc b/net/quic/core/crypto/crypto_utils_test.cc

index 340352337991288683669744c7bcb179d7f76c83..aac1926052a2242b648328daa647773367331b04 100644

--- a/net/quic/core/crypto/crypto_utils_test.cc

+++ b/net/quic/core/crypto/crypto_utils_test.cc

@@ -18,9 +18,8 @@ TEST(CryptoUtilsTest, IsValidSNI) {

EXPECT_FALSE(CryptoUtils::IsValidSNI("192.168.0.1"));

// SNI without any dot.

EXPECT_FALSE(CryptoUtils::IsValidSNI("somedomain"));

- // Invalid RFC2396 hostname

- // TODO(rtenneti): Support RFC2396 hostname.

- // EXPECT_FALSE(CryptoUtils::IsValidSNI("some_domain.com"));

+ // Invalid by RFC2396 but unfortunately domains of this form exist.

+ EXPECT_TRUE(CryptoUtils::IsValidSNI("some_domain.com"));

// An empty string must be invalid otherwise the QUIC client will try sending

// it.

EXPECT_FALSE(CryptoUtils::IsValidSNI(""));

« no previous file with comments | « net/quic/core/crypto/crypto_utils.cc ('k') | no next file » | no next file with comments »