Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: net/http/http_util_unittest.cc

Issue 2097263002: Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove IsValidHeaderValueRFC7230(). Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_util.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_util_unittest.cc
diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc
index 557d92367a1b28f13bb907e4c481648f102c05b7..a9b97d9eb29fe6aed0684baf48f9797dde776e56 100644
--- a/net/http/http_util_unittest.cc
+++ b/net/http/http_util_unittest.cc
@@ -1288,29 +1288,6 @@ TEST(HttpUtilTest, NameValuePairsIteratorStrictQuotesSingleQuotes) {
CheckNextNameValuePair(&parser, true, true, "ok", "it'"));
}
-TEST(HttpUtilTest, IsValidHeaderValueRFC7230) {
- EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230(""));
-
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(" "));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(" q"));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q "));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("\t"));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("\tq"));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\t"));
-
- EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q q"));
- EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q\tq"));
-
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(std::string("\0", 1)));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230(std::string("q\0q", 3)));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\rq"));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\nq"));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\x01q"));
- EXPECT_FALSE(HttpUtil::IsValidHeaderValueRFC7230("q\x7fq"));
-
- EXPECT_TRUE(HttpUtil::IsValidHeaderValueRFC7230("q\x80q"));
-}
-
TEST(HttpUtilTest, HasValidators) {
const char* const kMissing = "";
const char* const kEtagEmpty = "\"\"";
« no previous file with comments | « net/http/http_util.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698