Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

This is a partial revert of https://codereview.chromium.org/1374883002.
This CL removes these UMAs, because we don't have to watch the UMA continuously.

BUG=455099, 614107, 614109
Committed: https://crrev.com/b8a1970ad9f1317819bbccd88df46a4c9d53a516
Cr-Commit-Position: refs/heads/master@{#402502}

[hiroshige, 2016-06-26 11:05:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-26 11:05:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-26 12:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-26 12:09:15]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-06-27 07:22:05]

Description was changed from

==========
Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

BUG=455099, 614107, 614109
==========

to

==========
Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

This is a partial revert of https://codereview.chromium.org/1374883002.
This CL removes these UMAs, because we don't have to watch the UMA continuously.

BUG=455099, 614107, 614109
==========

[hiroshige, 2016-06-27 07:25:15]

hiroshige@chromium.org changed reviewers:
+ davidben@chromium.org, isherman@chromium.org, shiva.jm@samsung.com,
tyoshino@chromium.org

[hiroshige, 2016-06-27 07:25:16]

PTAL:
  davidben@: as a net/ owner.
  isherman@: as a tools/metric owner.

shiva.jm@ and tyoshino@, as you are related to Issue 455099; any comments on
removing these UMAs?

[tyoshino (SeeGerritForStatus), 2016-06-27 08:19:24]

lgtm

HttpUtil::IsValidHeaderValueRFC7230 can be removed?

[hiroshige, 2016-06-27 08:35:19]

On 2016/06/27 08:19:24, tyoshino wrote:
> HttpUtil::IsValidHeaderValueRFC7230 can be removed?
I'm neutral about removing it: we can remove it along with tests, or maybe we
can keep IsValidHeaderValueRFC7230() for potential future uses.
davidben@, WDYT?

[davidben, 2016-06-27 18:27:26]

On 2016/06/27 08:35:19, hiroshige wrote:
> On 2016/06/27 08:19:24, tyoshino wrote:
> > HttpUtil::IsValidHeaderValueRFC7230 can be removed?
> I'm neutral about removing it: we can remove it along with tests, or maybe we
> can keep IsValidHeaderValueRFC7230() for potential future uses.
> davidben@, WDYT?

If it's unused, I'd say we should remove it. We can always put it back if we end
up needing it. What was the result of the UMA? Did we conclude we couldn't do
it?

[Ilya Sherman, 2016-06-28 03:14:53]

LGTM, thanks!

[hiroshige, 2016-06-28 13:03:08]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 13:03:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 14:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 14:08:45]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-06-28 17:16:05]

On 2016/06/27 18:27:26, davidben wrote:
> On 2016/06/27 08:35:19, hiroshige wrote:
> > On 2016/06/27 08:19:24, tyoshino wrote:
> > > HttpUtil::IsValidHeaderValueRFC7230 can be removed?
> > I'm neutral about removing it: we can remove it along with tests, or maybe
we
> > can keep IsValidHeaderValueRFC7230() for potential future uses.
> > davidben@, WDYT?
> 
> If it's unused, I'd say we should remove it. We can always put it back if we
end
> up needing it.
I see, removed in Patch Set 2.

> What was the result of the UMA? Did we conclude we couldn't do it?
https://groups.google.com/a/chromium.org/d/msg/blink-dev/K5jd8Y5l6pI/QixtAILi...
> 0.1% (=A/C) of page loads is estimated to contain a request that contain at
least one invalid header value.
> This (~0.1%) is higher than the deprecation threshold (0.03%).
We need further investigation (e.g. what kind of invalid header values are used)
to proceed, but the activity is suspended for months.

[davidben, 2016-06-28 17:31:36]

lgtm

[hiroshige, 2016-06-28 17:33:50]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-06-28 17:33:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2097263002/#ps20001
(title: "Remove IsValidHeaderValueRFC7230().")

[commit-bot: I haz the power, 2016-06-28 17:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 17:43:13]

Description was changed from

==========
Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

This is a partial revert of https://codereview.chromium.org/1374883002.
This CL removes these UMAs, because we don't have to watch the UMA continuously.

BUG=455099, 614107, 614109
==========

to

==========
Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

This is a partial revert of https://codereview.chromium.org/1374883002.
This CL removes these UMAs, because we don't have to watch the UMA continuously.

BUG=455099, 614107, 614109
==========

[commit-bot: I haz the power, 2016-06-28 17:43:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 17:45:36]

Description was changed from

==========
Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

This is a partial revert of https://codereview.chromium.org/1374883002.
This CL removes these UMAs, because we don't have to watch the UMA continuously.

BUG=455099, 614107, 614109
==========

to

==========
Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs

This is a partial revert of https://codereview.chromium.org/1374883002.
This CL removes these UMAs, because we don't have to watch the UMA continuously.

BUG=455099, 614107, 614109

Committed: https://crrev.com/b8a1970ad9f1317819bbccd88df46a4c9d53a516
Cr-Commit-Position: refs/heads/master@{#402502}
==========

[commit-bot: I haz the power, 2016-06-28 17:45:37]

Patchset 2 (id:??) landed as
https://crrev.com/b8a1970ad9f1317819bbccd88df46a4c9d53a516
Cr-Commit-Position: refs/heads/master@{#402502}