Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2097263002: Deprecate Net.{HttpRequest,Response}.ContainsInvalidHeaderValuesInRFC7230 UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove IsValidHeaderValueRFC7230(). Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_util_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 336d798a5adf41a06d709ac578c74164926d15f9..823d358eb8a8847c0f2d3362abb1954248fb7ca6 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -610,17 +610,6 @@ void URLRequestHttpJob::StartTransactionInternal() {
// If we already have a transaction, then we should restart the transaction
// with auth provided by auth_credentials_.
- bool invalid_header_values_in_rfc7230 = false;
- for (HttpRequestHeaders::Iterator it(request_info_.extra_headers);
- it.GetNext();) {
- if (!HttpUtil::IsValidHeaderValueRFC7230(it.value())) {
- invalid_header_values_in_rfc7230 = true;
- break;
- }
- }
- UMA_HISTOGRAM_BOOLEAN("Net.HttpRequest.ContainsInvalidHeaderValuesInRFC7230",
- invalid_header_values_in_rfc7230);
-
int rv;
// Notify NetworkQualityEstimator.
@@ -1033,22 +1022,6 @@ void URLRequestHttpJob::OnStartCompleted(int result) {
}
scoped_refptr<HttpResponseHeaders> headers = GetResponseHeaders();
- if (headers) {
- size_t iter = 0;
- std::string name;
- std::string value;
- bool invalid_header_values_in_rfc7230 = false;
- while (headers->EnumerateHeaderLines(&iter, &name, &value)) {
- if (!HttpUtil::IsValidHeaderValueRFC7230(value)) {
- invalid_header_values_in_rfc7230 = true;
- break;
- }
- }
- UMA_HISTOGRAM_BOOLEAN(
- "Net.HttpResponse.ContainsInvalidHeaderValuesInRFC7230",
- invalid_header_values_in_rfc7230);
- }
-
if (network_delegate()) {
// Note that |this| may not be deleted until
// |on_headers_received_callback_| or
« no previous file with comments | « net/http/http_util_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698