content/public/browser/navigation_handle.h - Issue 2097083002: Update the CHECK in 'NavigationHandleImpl::GetRenderFrameHost()'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.h

Issue 2097083002: Update the CHECK in 'NavigationHandleImpl::GetRenderFrameHost()' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nasko@ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/navigation_handle.h

diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h

index 24a500ff82b6d3859511ed8ea76a99b5f228291f..54924a4ec63d1e616ce8f3c83a5b1847b2d0b92a 100644

--- a/content/public/browser/navigation_handle.h

+++ b/content/public/browser/navigation_handle.h

@@ -125,7 +125,12 @@ class CONTENT_EXPORT NavigationHandle {

virtual net::Error GetNetErrorCode() = 0;

// Returns the RenderFrameHost this navigation is taking place in. This can

- // only be accessed after the navigation is ready to commit.

+ // only be accessed after a response has been delivered for processing.

+ //

+ // If PlzNavigate is active, the RenderFrameHost returned will be the final

+ // host for the navigation. If PlzNavigate is inactive, the navigation may

+ // transfer to a new host up until the point that DidFinishNavigation is

+ // called.

virtual RenderFrameHost* GetRenderFrameHost() = 0;

// Whether the navigation happened in the same page. This is only known

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | no next file » | no next file with comments »