Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 2097083002: Update the CHECK in 'NavigationHandleImpl::GetRenderFrameHost()' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // handlers. 118 // handlers.
119 virtual bool IsExternalProtocol() = 0; 119 virtual bool IsExternalProtocol() = 0;
120 120
121 // Navigation control flow -------------------------------------------------- 121 // Navigation control flow --------------------------------------------------
122 122
123 // The net error code if an error happened prior to commit. Otherwise it will 123 // The net error code if an error happened prior to commit. Otherwise it will
124 // be net::OK. 124 // be net::OK.
125 virtual net::Error GetNetErrorCode() = 0; 125 virtual net::Error GetNetErrorCode() = 0;
126 126
127 // Returns the RenderFrameHost this navigation is taking place in. This can 127 // Returns the RenderFrameHost this navigation is taking place in. This can
128 // only be accessed after the navigation is ready to commit. 128 // only be accessed after a response has been delivered for processing.
129 //
130 // If PlzNavigate is active, the RenderFrameHost returned will be the final
131 // host for the navigation. If PlzNavigate is inactive, the navigation may
132 // transfer to a new host up until the point that DidFinishNavigation is
133 // called.
129 virtual RenderFrameHost* GetRenderFrameHost() = 0; 134 virtual RenderFrameHost* GetRenderFrameHost() = 0;
130 135
131 // Whether the navigation happened in the same page. This is only known 136 // Whether the navigation happened in the same page. This is only known
132 // after the navigation has committed. It is an error to call this method 137 // after the navigation has committed. It is an error to call this method
133 // before the navigation has committed. 138 // before the navigation has committed.
134 virtual bool IsSamePage() = 0; 139 virtual bool IsSamePage() = 0;
135 140
136 // Whether the navigation has encountered a server redirect or not. 141 // Whether the navigation has encountered a server redirect or not.
137 virtual bool WasServerRedirect() = 0; 142 virtual bool WasServerRedirect() = 0;
138 143
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 194
190 // The NavigationData that the embedder returned from 195 // The NavigationData that the embedder returned from
191 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will 196 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
192 // be a clone of the NavigationData. 197 // be a clone of the NavigationData.
193 virtual NavigationData* GetNavigationData() = 0; 198 virtual NavigationData* GetNavigationData() = 0;
194 }; 199 };
195 200
196 } // namespace content 201 } // namespace content
197 202
198 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 203 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698