Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2097083002: Update the CHECK in 'NavigationHandleImpl::GetRenderFrameHost()' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko@ Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/browser/navigation_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index a6267b6e28471d552d15d095eec511c5f3964c4c..a31508c18e0e1ec27973f27cbb510d2398d4090a 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -183,9 +183,12 @@ net::Error NavigationHandleImpl::GetNetErrorCode() {
}
RenderFrameHostImpl* NavigationHandleImpl::GetRenderFrameHost() {
- CHECK(state_ >= READY_TO_COMMIT)
- << "This accessor should only be called "
- "after the navigation is ready to commit.";
+ // TODO(mkwst): Change this to check against 'READY_TO_COMMIT' once
+ // ReadyToCommitNavigation is available whether or not PlzNavigate is
+ // enabled. https://crbug.com/621856
+ CHECK_GE(state_, WILL_PROCESS_RESPONSE)
+ << "This accessor should only be called after a response has been "
+ "delivered for processing.";
return render_frame_host_;
}
« no previous file with comments | « no previous file | content/public/browser/navigation_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698