Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 209703002: Shrink RenderLayerCompositor by 5% by removing unused code (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium, ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Shrink RenderLayerCompositor by 5% by removing unused code Remove has3DContent, layerHas3DContent The last vestiges of these functions were removed with https://src.chromium.org/viewvc/blink?revision=167695&view=revision when Abarth removed isSoftwareRenderable. Remove computeFixedViewportConstraints, computeStickyViewportConstraints Jamesr removed the last callers in https://src.chromium.org/viewvc/blink?view=rev&revision=147653 Remove clearMappingForAllRenderLayers, clearMappingForRenderLayerIncludingDescendants These functions were added (under a different name) by Simon Fraser in http://trac.webkit.org/changeset/90484. Jamesr removed the caller in https://codereview.chromium.org/13818029. Remove setCompositingParent, removeCompositedChildren This code predates written history and possibly humankind. Remove updateLayerTreeGeometry Abarth removed the implementation but left the function definition in https://src.chromium.org/viewvc/blink?view=rev&revision=168244 Remove updateGraphicsLayersMappedToRenderLayer Abarth removed the implementation but left the function definition in https://src.chromium.org/viewvc/blink?view=rev&revision=167697 Remove hasAnyAdditionalCompositedLayers Shawn Singh removed the implementation but left the function definition in https://src.chromium.org/viewvc/blink?view=rev&revision=163720 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -130 lines) Patch
M Source/core/rendering/compositing/RenderLayerCompositor.h View 4 chunks +0 lines, -19 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 4 chunks +0 lines, -111 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
pdr.
6 years, 9 months ago (2014-03-24 03:16:42 UTC) #1
abarth-chromium
Awesome patch! Sorry for not removing the declarations! LGTM
6 years, 9 months ago (2014-03-24 03:33:01 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 03:34:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/209703002/1
6 years, 9 months ago (2014-03-24 03:34:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 04:39:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 04:39:26 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 04:48:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/209703002/1
6 years, 9 months ago (2014-03-24 04:48:12 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 05:51:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 05:51:22 UTC) #10
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 06:23:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/209703002/1
6 years, 9 months ago (2014-03-24 06:23:52 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 07:25:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 07:25:34 UTC) #14
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 16:36:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/209703002/1
6 years, 9 months ago (2014-03-24 16:36:34 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 17:40:25 UTC) #17
Message was sent while issue was closed.
Change committed as 169866

Powered by Google App Engine
This is Rietveld 408576698