Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 13818029: Remove TiledBacking / TileCache code (Closed)

Created:
7 years, 8 months ago by jamesr
Modified:
7 years, 8 months ago
Reviewers:
eseidel, enne (OOO)
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, Stephen Chennney, Nate Chapin, Ian Vollick
Visibility:
Public.

Description

Remove TiledBacking / TileCache code We don't use this. All composited layers are tiled if necessary in a way that's invisible to WebCore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147978

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1439 lines) Patch
D LayoutTests/fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/WebCore/WebCore.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/history/CachedFrame.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/inspector/InspectorOverlay.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/WebCore/loader/EmptyClients.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/Chrome.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/Chrome.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/page/ChromeClient.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M Source/WebCore/page/Frame.h View 4 chunks +1 line, -29 lines 0 comments Download
M Source/WebCore/page/Frame.cpp View 4 chunks +1 line, -77 lines 0 comments Download
M Source/WebCore/page/FrameView.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 12 chunks +6 lines, -78 lines 0 comments Download
M Source/WebCore/page/Page.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/Settings.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M Source/WebCore/platform/HostWindow.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/platform/ScrollView.h View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/platform/ScrollView.cpp View 8 chunks +0 lines, -35 lines 0 comments Download
M Source/WebCore/platform/ScrollableArea.h View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/WebCore/platform/graphics/TiledBacking.h View 1 chunk +0 lines, -98 lines 0 comments Download
D Source/WebCore/platform/graphics/TiledBackingStore.h View 1 chunk +0 lines, -148 lines 0 comments Download
D Source/WebCore/platform/graphics/TiledBackingStore.cpp View 1 chunk +0 lines, -598 lines 0 comments Download
D Source/WebCore/platform/graphics/TiledBackingStoreBackend.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/WebCore/platform/graphics/TiledBackingStoreClient.h View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerBacking.h View 4 chunks +2 lines, -7 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerBacking.cpp View 1 10 chunks +1 line, -42 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.cpp View 1 2 chunks +21 lines, -38 lines 0 comments Download
M Source/WebCore/testing/Internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/testing/Internals.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
Out it goes! Ian - I've left behind a few hooks in RenderLayerBacking/RenderLayerCompositor related to ...
7 years, 8 months ago (2013-04-09 21:07:30 UTC) #1
eseidel
lgtm
7 years, 8 months ago (2013-04-09 21:28:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/13818029/36
7 years, 8 months ago (2013-04-09 21:29:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) compile, test_shell_tests, webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=3009
7 years, 8 months ago (2013-04-09 21:45:08 UTC) #4
jamesr
On 2013/04/09 21:29:09, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 8 months ago (2013-04-09 21:45:44 UTC) #5
jamesr
7 years, 8 months ago (2013-04-09 21:55:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r147978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698