Remove ParamStorageTraits::wrap and move unwrap to global scope (3/5)

Remove ParamStorageTraits::wrap and move unwrap to global scope

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=597856
Committed: https://crrev.com/db416620d2201afc6e2c7e89bfb1fad5e99fc22e
Cr-Commit-Position: refs/heads/master@{#402127}

[tzik, 2016-06-24 06:45:37]

Description was changed from

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

BUG=
==========

to

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

123456789012345678901234567890123456789012345678901234567890123456789012

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=
==========

[tzik, 2016-06-24 07:06:03]

Description was changed from

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

123456789012345678901234567890123456789012345678901234567890123456789012

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=
==========

to

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=597856
==========

[tzik, 2016-06-24 07:06:04]

tzik@chromium.org changed reviewers:
+ yutak@chromium.org

[tzik, 2016-06-24 07:06:33]

PTAL

[Yuta Kitamura, 2016-06-24 12:21:09]

Mostly LG.

https://codereview.chromium.org/2097013002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2097013002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:252: T Unwrap(const PassedWrapper<T>&
wrapped)
Is the "const&" the part of API requirement of Unwrap?

This Unwrap() does mutate the argument, so if it's possible
to make the argument non-const lvalue reference, that'd be
better.

[tzik, 2016-06-24 13:04:20]

https://codereview.chromium.org/2097013002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2097013002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:252: T Unwrap(const PassedWrapper<T>&
wrapped)
On 2016/06/24 12:21:09, Yuta Kitamura wrote:
> Is the "const&" the part of API requirement of Unwrap?
> 
> This Unwrap() does mutate the argument, so if it's possible
> to make the argument non-const lvalue reference, that'd be
> better.

Yes, it's going to be required.
This will be used by base::Callback once we rewrite WTF::bind on top of
base::Bind, and base::Callback will pass the value of internal storage by
const-ref when it's invoked in multi-call mode.

[Yuta Kitamura, 2016-06-27 06:04:39]

Then LGTM.

[tzik, 2016-06-27 06:22:39]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-06-27 06:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 07:09:00]

Description was changed from

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=597856
==========

to

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=597856
==========

[commit-bot: I haz the power, 2016-06-27 07:09:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-27 07:10:37]

Description was changed from

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=597856
==========

to

==========
Remove ParamStorageTraits::wrap and move unwrap to global scope

This removes ParamStorageTraits::wrap, which is no longer needed. Also,
moves ParamStorageTraits::unwrap to the global scope to align the usage
of base::internal::Unwrap.

BUG=597856

Committed: https://crrev.com/db416620d2201afc6e2c7e89bfb1fad5e99fc22e
Cr-Commit-Position: refs/heads/master@{#402127}
==========

[commit-bot: I haz the power, 2016-06-27 07:10:38]

Patchset 4 (id:??) landed as
https://crrev.com/db416620d2201afc6e2c7e89bfb1fad5e99fc22e
Cr-Commit-Position: refs/heads/master@{#402127}