Make WTF::Function be a base::Callback wrapper (5/5)

Make WTF::Function be a base::Callback wrapper

BUG=597856
Committed: https://crrev.com/949812d269dfc76c3d05f8d3854657e6aa4abe1b
Cr-Commit-Position: refs/heads/master@{#402136}

[tzik, 2016-06-24 14:26:26]

Description was changed from

==========
Make WTF::Function be a base::Callback wrapper

BUG=
==========

to

==========
Make WTF::Function be a base::Callback wrapper

BUG=597856
==========

[tzik, 2016-06-24 14:28:27]

tzik@chromium.org changed reviewers:
+ hiroshige@chromium.org, yutak@chromium.org

[tzik, 2016-06-24 14:28:27]

PTAL

[Yuta Kitamura, 2016-06-27 06:46:36]

Removing this scale of code in favor of base::Bind() is
simply awesome. Looks generally OK.

https://codereview.chromium.org/2092093002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2092093002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:251: return wrapUnique(new
Function<UnboundRunType, threadAffinity>(base::Bind(function, typename
ParamStorageTraits<typename
std::decay<BoundParameters>::type>::StorageType(std::forward<BoundParameters>(boundParameters))...)));
This line makes my brain cause a traffic jam... Let me confirm
my understanding. Are these true or false?

1. The former "wrap()" is now replaced with a constructor call
   of StorageType.
2. The former "unwrap()" is replaced with Unwrap(), which is
   dealt by base::Bind().

[tzik, 2016-06-27 06:53:43]

https://codereview.chromium.org/2092093002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2092093002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:251: return wrapUnique(new
Function<UnboundRunType, threadAffinity>(base::Bind(function, typename
ParamStorageTraits<typename
std::decay<BoundParameters>::type>::StorageType(std::forward<BoundParameters>(boundParameters))...)));
On 2016/06/27 06:46:36, Yuta Kitamura wrote:
> This line makes my brain cause a traffic jam... Let me confirm
> my understanding. Are these true or false?
> 
> 1. The former "wrap()" is now replaced with a constructor call
>    of StorageType.
> 2. The former "unwrap()" is replaced with Unwrap(), which is
>    dealt by base::Bind().

Agree. It's too long to look at a glance...
1. Yes, wrap is replaced with the constructor call. Ideally, we should add
another traits to specify the storage type to base::Bind and should get rid of
the constructor call...
2. Yes, exactly.

[Yuta Kitamura, 2016-06-27 08:01:20]

OK, LGTM.

[hiroshige, 2016-06-27 08:30:58]

lgtm!

[tzik, 2016-06-27 08:32:45]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-06-27 08:33:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 08:36:26]

Description was changed from

==========
Make WTF::Function be a base::Callback wrapper

BUG=597856
==========

to

==========
Make WTF::Function be a base::Callback wrapper

BUG=597856
==========

[commit-bot: I haz the power, 2016-06-27 08:36:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-27 08:37:56]

Description was changed from

==========
Make WTF::Function be a base::Callback wrapper

BUG=597856
==========

to

==========
Make WTF::Function be a base::Callback wrapper

BUG=597856

Committed: https://crrev.com/949812d269dfc76c3d05f8d3854657e6aa4abe1b
Cr-Commit-Position: refs/heads/master@{#402136}
==========

[commit-bot: I haz the power, 2016-06-27 08:37:57]

Patchset 5 (id:??) landed as
https://crrev.com/949812d269dfc76c3d05f8d3854657e6aa4abe1b
Cr-Commit-Position: refs/heads/master@{#402136}

[haraken, 2016-06-27 09:24:34]

LGTM