content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/gpu_output_surface_mac.mm ('k') | content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

index a091d3efe0c5c59575cdbc2bf430047051186923..d154bb23f6e71de84521b210043fe4159345c6bf 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

@@ -37,7 +37,7 @@ class GpuSurfacelessBrowserCompositorOutputSurface

~GpuSurfacelessBrowserCompositorOutputSurface() override;

// cc::OutputSurface implementation.

- void SwapBuffers(cc::CompositorFrame* frame) override;

+ void SwapBuffers(cc::CompositorFrame frame) override;

void OnSwapBuffersComplete() override;

void BindFramebuffer() override;

uint32_t GetFramebufferCopyTextureFormat() override;