content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h ('k') | content/browser/compositor/offscreen_browser_compositor_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

index d9a9371df78da4927ef7f77de87695fbce59321f..6dc2687b5ba680831f263f21b9e4b1707b6379a4 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

@@ -69,10 +69,10 @@ unsigned GpuSurfacelessBrowserCompositorOutputSurface::GetOverlayTextureId()

}

void GpuSurfacelessBrowserCompositorOutputSurface::SwapBuffers(

- cc::CompositorFrame* frame) {

+ cc::CompositorFrame frame) {

DCHECK(buffer_queue_);

- buffer_queue_->SwapBuffers(frame->gl_frame_data->sub_buffer_rect);

- GpuBrowserCompositorOutputSurface::SwapBuffers(frame);

+ buffer_queue_->SwapBuffers(frame.gl_frame_data->sub_buffer_rect);

+ GpuBrowserCompositorOutputSurface::SwapBuffers(std::move(frame));

}

void GpuSurfacelessBrowserCompositorOutputSurface::OnSwapBuffersComplete() {