content/browser/compositor/gpu_output_surface_mac.mm - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_output_surface_mac.mm

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/compositor/gpu_output_surface_mac.mm

diff --git a/content/browser/compositor/gpu_output_surface_mac.mm b/content/browser/compositor/gpu_output_surface_mac.mm

index 02552b9daebadbfc760389699f45cf4291a22f20..e728906283658072755651b24c104925a5974406 100644

--- a/content/browser/compositor/gpu_output_surface_mac.mm

+++ b/content/browser/compositor/gpu_output_surface_mac.mm

@@ -4,6 +4,7 @@

#include "content/browser/compositor/gpu_output_surface_mac.h"

+#include "cc/output/compositor_frame.h"

#include "components/display_compositor/compositor_overlay_candidate_validator.h"

#include "content/browser/gpu/gpu_surface_tracker.h"

#include "content/common/gpu/client/context_provider_command_buffer.h"

@@ -66,8 +67,8 @@ GpuOutputSurfaceMac::GpuOutputSurfaceMac(

GpuOutputSurfaceMac::~GpuOutputSurfaceMac() {}

-void GpuOutputSurfaceMac::SwapBuffers(cc::CompositorFrame* frame) {

- GpuSurfacelessBrowserCompositorOutputSurface::SwapBuffers(frame);

+void GpuOutputSurfaceMac::SwapBuffers(cc::CompositorFrame frame) {

+ GpuSurfacelessBrowserCompositorOutputSurface::SwapBuffers(std::move(frame));

if (should_show_frames_state_ ==

SHOULD_NOT_SHOW_FRAMES_NO_SWAP_AFTER_SUSPENDED) {