chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html - Issue 2094813002: MD Settings: make custom UIs look "actionable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html ('k') | chrome/browser/resources/settings/people_page/people_page.html » ('j') | chrome/browser/resources/settings/people_page/people_page.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

index fe50a2bd1da74db413f1c86c1571dd0de64d9254..dbf619aeabaa548a1a122342f2a8190c63ea3dc6 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

@@ -89,10 +89,10 @@

</iron-list>

</div>

<cr-shared-menu id="menu">

- <div id="menuEditPassword" class="list-item menu-item"

+ <div id="menuEditPassword" class="list-item menu-item" actionable

dpapad 2016/06/23 20:51:45 Same question/suggestion here.

Dan Beam 2016/06/23 21:28:03 Done.

on-tap="onMenuEditPasswordTap_"

hidden="[[!showPasswords]]">$i18n{editPassword}</div>

- <div id="menuRemovePassword" class="list-item menu-item"

+ <div id="menuRemovePassword" class="list-item menu-item" actionable

on-tap="onMenuRemovePasswordTap_">$i18n{removePassword}</div>

</cr-shared-menu>

<password-edit-dialog id="passwordEditDialog"></password-edit-dialog>