chrome/browser/resources/settings/people_page/people_page.html - Issue 2094813002: MD Settings: make custom UIs look "actionable"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | chrome/browser/resources/settings/people_page/sync_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/people_page.html

diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html

index ec8a304cbda559c8ad46968f27912e168ee18a39..d999df377c3ef20e107795b37ddc392d169d9df8 100644

--- a/chrome/browser/resources/settings/people_page/people_page.html

+++ b/chrome/browser/resources/settings/people_page/people_page.html

@@ -44,17 +44,11 @@

cursor: pointer;

}

-<if expr="not chromeos">

- #profile-name:hover {

- cursor: pointer;

- }

-</if>

Dan Beam 2016/06/23 19:20:01 redundant

#sync-icon {

margin: 0 10px;

}

- iron-icon[icon="settings:sync-problem"] {

+ iron-icon[icon='settings:sync-problem'] {

Dan Beam 2016/06/23 19:20:01 presubmit

--iron-icon-fill-color: var(--settings-error-color);

}

@@ -80,14 +74,14 @@

<neon-animatable id="main">

<img id="profile-icon" src="[[profileIconUrl_]]"

- on-tap="onPictureTap_">

+ on-tap="onPictureTap_" actionable>

-<if expr="chromeos">

- <span id="profile-name" on-tap="onProfileNameTap_">

+<if expr="not chromeos">

+ <span id="profile-name" on-tap="onProfileNameTap_" actionable>

[[profileName_]]

</span>

</if>

-<if expr="not chromeos">

Dan Beam 2016/06/23 19:20:00 talked with tommycli@: this was reversed (as I sus

+<if expr="chromeos">

[[profileName_]]

</span>

@@ -118,7 +112,7 @@

<template is="dom-if"

if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]">

- <div class="settings-box two-line" on-tap="onSyncTap_">

+ <div class="settings-box two-line" on-tap="onSyncTap_" actionable>

<iron-icon id="sync-icon" icon$="[[getSyncIcon_(syncStatus)]]">

</iron-icon>

@@ -135,7 +129,7 @@

</template>

<div class="settings-box two-line" id="activity-controls"

- on-tap="onActivityControlsTap_">

+ on-tap="onActivityControlsTap_" actionable>

</div>