chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html - Issue 2094813002: MD Settings: make custom UIs look "actionable"

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html ('K') | « chrome/browser/resources/settings/on_startup_page/startup_urls_page.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html » ('j') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

index ea6ed09c63bdf08d1a602bfc416336a49cb8ec4c..b973d73f7871e1bf5e62e14f8538325bcfac78a0 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

@@ -48,9 +48,9 @@

</div>

<cr-shared-menu id="addressSharedMenu">

- <div id="menuEditAddress" class="list-item menu-item"

+ <div id="menuEditAddress" class="list-item menu-item" actionable

dpapad 2016/06/23 20:51:45 We could also add the @apply(--settings-actionable

Dan Beam 2016/06/23 21:28:03 guess that's OK with me. i'll apply this logic to

dpapad 2016/06/23 22:07:45 password_section.html could also use similar metho

Dan Beam 2016/06/23 23:31:49 Done.

on-tap="onMenuEditAddressTap_">$i18n{editAddress}</div>

- <div id="menuRemoveAddress" class="list-item menu-item"

+ <div id="menuRemoveAddress" class="list-item menu-item" actionable

on-tap="onMenuRemoveAddressTap_">$i18n{removeAddress}</div>

</cr-shared-menu>

<div class="heading">$i18n{creditCards}</div>

@@ -83,9 +83,9 @@

</div>

<cr-shared-menu id="creditCardSharedMenu">

- <div id="menuEditCreditCard" class="list-item menu-item"

+ <div id="menuEditCreditCard" class="list-item menu-item" actionable

on-tap="onMenuEditCreditCardTap_">$i18n{editCreditCard}</div>

- <div id="menuRemoveCreditCard" class="list-item menu-item"

+ <div id="menuRemoveCreditCard" class="list-item menu-item" actionable

on-tap="onMenuRemoveCreditCardTap_">$i18n{removeCreditCard}</div>

</cr-shared-menu>

<settings-credit-card-edit-dialog id="editCreditCardDialog">