Issue 209443002: Renamed MediaQueryExp::create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209443002: Renamed MediaQueryExp::create (Closed)

Created:
6 years, 9 months ago by Yoav Weiss

Modified:
6 years, 9 months ago

Reviewers:
eseidel

CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@bison_parser_cleanup

Visibility:
Public.

Renamed MediaQueryExp::create Since MediaQueryExp::create returns a nullptr when the input string is not a valid media feature, I've renamed it to createIfValid. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169801

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	Source/core/css/MediaQueryExp.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/MediaQueryExp.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/css/parser/BisonCSSParser-in.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/parser/MediaQueryParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Yoav Weiss

Following the review on https://codereview.chromium.org/171383002 , I've renamed MediaQueryExp::create

6 years, 9 months ago (2014-03-22 17:24:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/209443002/1

6 years, 9 months ago (2014-03-22 17:33:28 UTC) #3

Message was sent while issue was closed.

Change committed as 169801