Source/core/css/parser/MediaQueryParser.cpp - Issue 209443002: Renamed MediaQueryExp::create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/MediaQueryParser.cpp

Issue 209443002: Renamed MediaQueryExp::create (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bison_parser_cleanup

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/MediaQueryParser.cpp

diff --git a/Source/core/css/parser/MediaQueryParser.cpp b/Source/core/css/parser/MediaQueryParser.cpp

index 8340dd12fa9b69b5d4d9111d9a2538e71370bd16..1e1f9e3e0be7f597d26cf2e9ab7198d3c476825c 100644

--- a/Source/core/css/parser/MediaQueryParser.cpp

+++ b/Source/core/css/parser/MediaQueryParser.cpp

@@ -207,7 +207,7 @@ PassOwnPtrWillBeRawPtr<MediaQuery> MediaQueryData::takeMediaQuery()

bool MediaQueryData::addExpression()

{

- OwnPtrWillBeRawPtr<MediaQueryExp> expression = MediaQueryExp::create(m_mediaFeature, &m_valueList);

+ OwnPtrWillBeRawPtr<MediaQueryExp> expression = MediaQueryExp::createIfValid(m_mediaFeature, &m_valueList);

bool isValid = !!expression;

m_expressions->append(expression.release());

m_valueList.clear();

« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | no next file » | no next file with comments »