Source/core/css/MediaQueryExp.cpp - Issue 209443002: Renamed MediaQueryExp::create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryExp.cpp

Issue 209443002: Renamed MediaQueryExp::create (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bison_parser_cleanup

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryExp.cpp

diff --git a/Source/core/css/MediaQueryExp.cpp b/Source/core/css/MediaQueryExp.cpp

index c85c928db4a67f0277d72cb1b020c758b661a9b9..68cb8f8ca27bc08bdf060235fc96a31068bd3bfe 100644

--- a/Source/core/css/MediaQueryExp.cpp

+++ b/Source/core/css/MediaQueryExp.cpp

@@ -211,8 +211,7 @@ MediaQueryExp::MediaQueryExp(const String& mediaFeature, PassRefPtrWillBeRawPtr<

{

}

-// FIXME - create should not return a null.

-PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::create(const String& mediaFeature, CSSParserValueList* valueList)

+PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::createIfValid(const String& mediaFeature, CSSParserValueList* valueList)

{

ASSERT(!mediaFeature.isNull());

« no previous file with comments | « Source/core/css/MediaQueryExp.h ('k') | Source/core/css/parser/BisonCSSParser-in.cpp » ('j') | no next file with comments »