Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/app/chromeos_strings.grdp

Index: chrome/app/chromeos_strings.grdp
diff --git a/chrome/app/chromeos_strings.grdp b/chrome/app/chromeos_strings.grdp
index 23e361aef12767c9c597963e11b03dbed63672c9..ff5f33c2d46280c8a6ca4bc02cd2a9664afcc759 100644
--- a/chrome/app/chromeos_strings.grdp
+++ b/chrome/app/chromeos_strings.grdp
@@ -6295,7 +6295,7 @@ All users must sign out to continue.
   </message>
   <message name="IDS_FLAGS_ENABLE_IME_MENU_NAME" desc="Name of the about: flag for enabling opt-in IME menu.">
     Enable opt-in IME menu
-    </message>
+  </message>
   <message name="IDS_FLAGS_ENABLE_IME_MENU_DESCRIPTION" desc="Description of the about: flag for enabling opt-in IME menu.">
     Enable access to the new IME menu in the Language Settings page.
   </message>
@@ -6323,4 +6323,32 @@ All users must sign out to continue.
   <message name="IDS_HATS_DONE_BUTTON_LABEL" desc="Label used for the done button at the end of survey">
     Done
   </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_HEADER" desc="The text displayed in the dialog to request the PIN/PUK by extension.">

[emaxx, 2016/09/19 14:01:43]

nit: Please make all the descriptions that refer to the PIN dialog look uniform.
Currently, the first description includes the text "the dialog to request the
PIN/PUK by extension", some other descriptions include the text "requestPin
dialog", and other descriptions don't mention the attribution at all.
I'd suggest to reformat all descriptions so that they all have some clear
distinguishing "marker" - e.g.:
"the certificate provider PIN request dialog".

[igorcov, 2016/09/19 15:42:36]

Done.

+    "<ph name="EXT_NAME">$1<ex>My Extension</ex></ph>" is requesting your <ph name="CODE_TYPE">$2<ex>PIN</ex></ph>

[emaxx, 2016/09/19 14:01:43]

nit: s/EXT_/EXTENSION_/
(it's always better to not shorten words in the names)

[igorcov, 2016/09/19 15:42:36]

Done.

+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_PROCESSING" desc="The text displayed while the API is waiting for notification request from extension.">
+    Processing request...
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_INVALID_PIN_ERROR" desc="The error message displayed in requestPin dialog when invalid PIN was entered.">
+    Invalid PIN.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_INVALID_PUK_ERROR" desc="The error message displayed in requestPin dialog when invalid PUK was entered.">
+    Invalid PUK.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_MAX_ATTEMPTS_EXCEEDED_ERROR" desc="The error message displayed in requestPin dialog when maximum allowed attempts exceeded.">
+    Maximum allowed attempts exceeded.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_UNKNOWN_ERROR" desc="The error message displayed in requestPin dialog when unexpected error occurred in extension code.">

[emaxx, 2016/09/19 14:01:43]

nit: s/unexpected/unknown/
(because the error itself may be well expected in this or that case, but it's
just that API doesn't provide a corresponding standard message for it)

[igorcov, 2016/09/19 15:42:36]

Done.

+    Unknown error.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_ATTEMPTS_LEFT" desc="The text displayed to the user about the number of attempts left">
+    Attempts left: $1
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_PIN" desc="The Provider Identification Number abbreviation">
+    PIN
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_PUK" desc="The Personal Unlocking Key (as used in mobile phones) abbreviation">
+    PUK
+  </message>
+
 </grit-part>