Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc

Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
index 2edf5e78866c303e2db3a4d7607dd30fe2294430..89f4d5ca2789cb76b1c86115c862da44e2173509 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
@@ -14,6 +14,7 @@
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/singleton.h"
+#include "base/rand_util.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
@@ -112,6 +113,8 @@ bool DefaultDelegate::DispatchSignRequestToExtension(
     return false;
 
   api_cp::SignRequest request;
+  service_->pin_dialog_manager()->AddSignRequestId(extension_id, request_id);

[emaxx, 2016/09/19 14:01:43]

The AddSignRequestId method returns boolean value that indicates whether the
operation was successful, but this is ignored here.
Will the subsequent code work correctly when adding finished unsuccessfully?

[igorcov, 2016/09/19 15:42:36]

In the new implementation it's impossible to have the id already in the map.
Changed the function signature to not return anything.

+  request.sign_request_id = request_id;
   switch (hash) {
     case net::SSLPrivateKey::Hash::MD5_SHA1:
       request.hash = api_cp::HASH_MD5_SHA1;