Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/app/chromeos_strings.grdp

 <?xml version="1.0" encoding="utf-8"?>
 <!-- ChromeOS-specific strings (included from generated_resources.grd).
      Everything in this file is wrapped in <if expr="chromeos">. -->
 <grit-part>
   <message name="IDS_EMPTY_STRING" desc="Empty string, exist only to make code generic. No translation required.">
   </message>
   <!-- Idle logout dialog for retail mode -->
   <message name="IDS_IDLE_LOGOUT_TITLE" desc="Dialog title for the idle logout dialog. Used in retail mode only.">
     Are you still there?
   </message>
@@ skipping 6277 matching lines @@
     Your organization has not enabled Google Play Store for your account. Contact your administrator for more information.
   </message>
   <message name="IDS_ARC_CRITICALLY_LOW_DISK_NOTIFICATION_TITLE" desc="Title of the notification warning users that they are critically low on disk space and Android apps can not be launched.">
     Device disk space critically low
   </message>
   <message name="IDS_ARC_CRITICALLY_LOW_DISK_NOTIFICATION_MESSAGE" desc="Notification text warning users that they are critically low on disk space and Android apps can not be launched.">
     Free up disk space to launch Android apps.
   </message>
   <message name="IDS_FLAGS_ENABLE_IME_MENU_NAME" desc="Name of the about: flag for enabling opt-in IME menu.">
     Enable opt-in IME menu
-    </message>
+  </message>
   <message name="IDS_FLAGS_ENABLE_IME_MENU_DESCRIPTION" desc="Description of the about: flag for enabling opt-in IME menu.">
     Enable access to the new IME menu in the Language Settings page.
   </message>
   <message name="IDS_LOW_DISK_NOTIFICATION_TITLE" desc="Title of the notification warning users that they are low on disk space.">
     Device is low on disk space
   </message>
   <message name="IDS_LOW_DISK_NOTIFICATION_MESSAGE" desc="Notification text warning users that they are low on disk space.">
     Free up disk space or select data may be automatically deleted
   </message>
   <message name="IDS_CRITICALLY_LOW_DISK_NOTIFICATION_TITLE" desc="Title of the notification warning users that they are critically low on disk space.">
     Device disk space critically low
   </message>
   <message name="IDS_CRITICALLY_LOW_DISK_NOTIFICATION_MESSAGE" desc="Notification text warning users that they are critically low on disk space.">
     Free up disk space or device will become unresponsive.
   </message>
   <message name="IDS_LOW_DISK_NOTIFICATION_BUTTON" desc="Button on the low disk notification to open storage management.">
     Manage storage
   </message>
   <message name="IDS_FLAGS_ENABLE_EHV_INPUT_NAME" desc="Name of the about: flag for enabling emoji, handwriting and voice input on opt-in IME menu.">
     Emoji, handwriting and voice input on opt-in IME menu
     </message>
   <message name="IDS_FLAGS_ENABLE_EHV_INPUT_DESCRIPTION" desc="Description of the about: flag enabling emoji, handwriting and voice input on opt-in IME menu.">
     Enable access to emoji, handwriting and voice input form opt-in IME menu.
   </message>
   <message name="IDS_HATS_DONE_BUTTON_LABEL" desc="Label used for the done button at the end of survey">
     Done
   </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_HEADER" desc="The text displayed in the dialog to request the PIN/PUK by extension.">

[emaxx, 2016/09/19 14:01:43]

nit: Please make all the descriptions that refer to the PIN dialog look uniform.
Currently, the first description includes the text "the dialog to request the
PIN/PUK by extension", some other descriptions include the text "requestPin
dialog", and other descriptions don't mention the attribution at all.
I'd suggest to reformat all descriptions so that they all have some clear
distinguishing "marker" - e.g.:
"the certificate provider PIN request dialog".

[igorcov, 2016/09/19 15:42:36]

Done.

+    "<ph name="EXT_NAME">$1<ex>My Extension</ex></ph>" is requesting your <ph name="CODE_TYPE">$2<ex>PIN</ex></ph>

[emaxx, 2016/09/19 14:01:43]

nit: s/EXT_/EXTENSION_/
(it's always better to not shorten words in the names)

[igorcov, 2016/09/19 15:42:36]

Done.

+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_PROCESSING" desc="The text displayed while the API is waiting for notification request from extension.">
+    Processing request...
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_INVALID_PIN_ERROR" desc="The error message displayed in requestPin dialog when invalid PIN was entered.">
+    Invalid PIN.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_INVALID_PUK_ERROR" desc="The error message displayed in requestPin dialog when invalid PUK was entered.">
+    Invalid PUK.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_MAX_ATTEMPTS_EXCEEDED_ERROR" desc="The error message displayed in requestPin dialog when maximum allowed attempts exceeded.">
+    Maximum allowed attempts exceeded.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_UNKNOWN_ERROR" desc="The error message displayed in requestPin dialog when unexpected error occurred in extension code.">

[emaxx, 2016/09/19 14:01:43]

nit: s/unexpected/unknown/
(because the error itself may be well expected in this or that case, but it's
just that API doesn't provide a corresponding standard message for it)

[igorcov, 2016/09/19 15:42:36]

Done.

+    Unknown error.
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_ATTEMPTS_LEFT" desc="The text displayed to the user about the number of attempts left">
+    Attempts left: $1
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_PIN" desc="The Provider Identification Number abbreviation">
+    PIN
+  </message>
+  <message name="IDS_REQUEST_PIN_DIALOG_PUK" desc="The Personal Unlocking Key (as used in mobile phones) abbreviation">
+    PUK
+  </message>
+
 </grit-part>