WebAudio: Remove legacy support for numerical values for Oscillator types.

WebAudio: Remove legacy support for numerical values for Oscillator types.

BUG=346522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171098

[Raymond Toy, 2014-04-08 17:35:02]

PTAL.

[Raymond Toy, 2014-04-08 17:36:08]

haraken@chromium.org: Please review changes in 

Source/bindings

[Ken Russell (switch to Gerrit), 2014-04-08 17:48:21]

LGTM overall. One point.

https://codereview.chromium.org/209423006/diff/80001/LayoutTests/webaudio/osc...
File LayoutTests/webaudio/oscillator-basic.html (right):

https://codereview.chromium.org/209423006/diff/80001/LayoutTests/webaudio/osc...
LayoutTests/webaudio/oscillator-basic.html:52: if (osc.type == "custom")
The fact that the OscillatorType enum contains "custom", but setting the
property to that value is ignored, violates the Web IDL spec as far as I can
tell.

[Raymond Toy, 2014-04-08 18:34:20]

https://codereview.chromium.org/209423006/diff/80001/LayoutTests/webaudio/osc...
File LayoutTests/webaudio/oscillator-basic.html (right):

https://codereview.chromium.org/209423006/diff/80001/LayoutTests/webaudio/osc...
LayoutTests/webaudio/oscillator-basic.html:52: if (osc.type == "custom")
On 2014/04/08 17:48:22, Ken Russell wrote:
> The fact that the OscillatorType enum contains "custom", but setting the
> property to that value is ignored, violates the Web IDL spec as far as I can
> tell.

Good point. I think this is a spec issue; I'll try to get clarification on this.

[haraken, 2014-04-08 23:18:42]

LGTM for bindings/.

[Raymond Toy, 2014-04-08 23:38:11]

On 2014/04/08 23:18:42, haraken wrote:
> LGTM for bindings/.

Thanks for the reviews!

[Raymond Toy, 2014-04-08 23:38:17]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2014-04-08 23:38:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtoy@chromium.org/209423006/80001

[commit-bot: I haz the power, 2014-04-08 23:38:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-08 23:38:38]

Failed to apply patch for Source/bindings/bindings.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/bindings.gypi
  Hunk #1 FAILED at 211.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/bindings.gypi.rej

Patch:       Source/bindings/bindings.gypi
Index: Source/bindings/bindings.gypi
diff --git a/Source/bindings/bindings.gypi b/Source/bindings/bindings.gypi
index
dae68a2ec6c1974b8023f1561de2262949293c0d..b03f8cafbdacfb2ea88c2e9227ae51e5805e2b6c
100644
--- a/Source/bindings/bindings.gypi
+++ b/Source/bindings/bindings.gypi
@@ -211,7 +211,6 @@
             'v8/custom/V8MessagePortCustom.cpp',
             'v8/custom/V8MutationObserverCustom.cpp',
             'v8/custom/V8NodeCustom.cpp',
-            'v8/custom/V8OscillatorNodeCustom.cpp',
             'v8/custom/V8PannerNodeCustom.cpp',
             'v8/custom/V8PerformanceEntryCustom.cpp',
             'v8/custom/V8PopStateEventCustom.cpp',

[Raymond Toy, 2014-04-09 00:02:47]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2014-04-09 00:02:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtoy@chromium.org/209423006/100001

[commit-bot: I haz the power, 2014-04-09 01:13:01]

Change committed as 171098