Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp

Issue 209423006: WebAudio: Remove legacy support for numerical values for Oscillator types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/modules/webaudio/OscillatorNode.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution.
12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y
17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N
20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */
24
25 #include "config.h"
26 #if ENABLE(WEB_AUDIO)
27 #include "V8OscillatorNode.h"
28
29 #include "bindings/v8/ExceptionState.h"
30 #include "bindings/v8/V8Binding.h"
31 #include "modules/webaudio/OscillatorNode.h"
32
33 namespace WebCore {
34
35 void V8OscillatorNode::typeAttributeSetterCustom(v8::Local<v8::Value> value, con st v8::PropertyCallbackInfo<void>& info)
36 {
37 ExceptionState exceptionState(ExceptionState::SetterContext, "type", "Oscill atorNode", info.Holder(), info.GetIsolate());
38 v8::Handle<v8::Object> holder = info.Holder();
39 OscillatorNode* impl = V8OscillatorNode::toNative(holder);
40
41 if (value->IsNumber()) {
42 uint32_t type = toUInt32(value, exceptionState);
43 if (exceptionState.throwIfNeeded())
44 return;
45 if (!impl->setType(type)) {
46 exceptionState.throwTypeError("Illegal OscillatorNode type");
47 exceptionState.throwIfNeeded();
48 }
49 return;
50 }
51
52 if (value->IsString()) {
53 String type = toCoreString(value.As<v8::String>());
54 if (type == "sine" || type == "square" || type == "sawtooth" || type == "triangle") {
55 impl->setType(type);
56 return;
57 }
58 }
59
60 exceptionState.throwTypeError("Illegal OscillatorNode type");
61 exceptionState.throwIfNeeded();
62 }
63
64 } // namespace WebCore
65
66 #endif // ENABLE(WEB_AUDIO)
OLDNEW
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/modules/webaudio/OscillatorNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698