Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2094213002: Expose readonly animation timeline (Closed)

Created:
4 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 5 months ago
CC:
Eric Willigers, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, rjwright, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose readonly animation timeline This patch exposes the Animation.timeline attribute in Animation.idl, as a readonly attribute with mutability left as a TODO. By exposing this feature, a few more of the Web Animations web platform tests pass. Two tests go from failing to flaky: - imported/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay.html - imported/wpt/web-animations/interfaces/Animation/playbackRate.html Where previously these tests failed because timeline was undefined, they now fail due to values of the timeline sometimes not being as expected, which is a separate issue. Something very similar to this patch had previously been submitted in crrev.com/1942683002 but was reverted due to these flakes. BUG=600248 Committed: https://crrev.com/db3111da7cc597a3dae3386281203199aa0b382d Cr-Commit-Position: refs/heads/master@{#403051}

Patch Set 1 #

Patch Set 2 : Update test expectation for new WPT test #

Messages

Total messages: 30 (13 generated)
suzyh_UTC10 (ex-contributor)
4 years, 5 months ago (2016-06-27 06:54:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094213002/1
4 years, 5 months ago (2016-06-27 06:54:58 UTC) #5
suzyh_UTC10 (ex-contributor)
I just realised that we had attempted to land (something very similar to) this patch ...
4 years, 5 months ago (2016-06-27 07:34:31 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 08:12:28 UTC) #9
Eric Willigers
lgtm
4 years, 5 months ago (2016-06-28 00:15:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094213002/1
4 years, 5 months ago (2016-06-28 00:18:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/208131)
4 years, 5 months ago (2016-06-28 00:34:06 UTC) #14
suzyh_UTC10 (ex-contributor)
+alancutter for OWNERS approval
4 years, 5 months ago (2016-06-28 00:52:17 UTC) #16
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-06-29 06:04:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094213002/1
4 years, 5 months ago (2016-06-29 06:06:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/254539)
4 years, 5 months ago (2016-06-29 07:33:33 UTC) #21
suzyh_UTC10 (ex-contributor)
On 2016/06/29 at 07:33:33, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng ...
4 years, 5 months ago (2016-06-29 23:23:30 UTC) #22
Eric Willigers
lgtm
4 years, 5 months ago (2016-06-29 23:31:51 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094213002/20001
4 years, 5 months ago (2016-06-29 23:39:44 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 01:14:39 UTC) #27
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 01:14:50 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 01:16:37 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db3111da7cc597a3dae3386281203199aa0b382d
Cr-Commit-Position: refs/heads/master@{#403051}

Powered by Google App Engine
This is Rietveld 408576698