Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1942683002: Web Animations: Expose timeline attributes on Animation object (experimental only) (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Expose timeline attributes on Animation object (experimental only) Simply exposing this attribute lets us pass a few more web-platform-tests. This brings us closer to the spec IDL for Animation: http://w3c.github.io/web-animations/#dom-animation-timeline BUG=600248 Committed: https://crrev.com/a5e6866bfac27205bf03797613978df3320a6930 Cr-Commit-Position: refs/heads/master@{#390900}

Patch Set 1 #

Messages

Total messages: 15 (6 generated)
alancutter (OOO until 2018)
4 years, 7 months ago (2016-05-02 05:14:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942683002/1
4 years, 7 months ago (2016-05-02 05:16:47 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm Add spec link to CL description for completeness.
4 years, 7 months ago (2016-05-02 05:17:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 06:39:49 UTC) #7
alancutter (OOO until 2018)
On 2016/05/02 at 05:17:20, suzyh wrote: > lgtm > > Add spec link to CL ...
4 years, 7 months ago (2016-05-02 07:10:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942683002/1
4 years, 7 months ago (2016-05-02 07:11:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 07:51:10 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5e6866bfac27205bf03797613978df3320a6930 Cr-Commit-Position: refs/heads/master@{#390900}
4 years, 7 months ago (2016-05-02 07:52:24 UTC) #14
dvadym
4 years, 7 months ago (2016-05-02 12:47:12 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1939733002/ by dvadym@chromium.org.

The reason for reverting is: It breaks
imported/web-platform-tests/web-animations/animation/playbackRate.html test on
Windows
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg) and
Linux webkit bots. For example 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg....

Powered by Google App Engine
This is Rietveld 408576698