Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2093943002: Have gpu createTestingOlyBackendTexture know if it is a render target or not (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@moreUnitTests
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have gpu createTestingOlyBackendTexture know if it is a render target or not In Vulkan we need to know at create time of a texture whether or not we will use it as a render target. BUG=skia:5458 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093943002 Committed: https://skia.googlesource.com/skia/+/0a3a7f7303273151f1585b3cf5f6968e3932bfed

Patch Set 1 #

Patch Set 2 : Have gpu createTestingOlyBackendTexture know if it is a render target or not #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M src/gpu/GrGpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 4 chunks +15 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/VkWrapTests.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
egdaniel
4 years, 5 months ago (2016-06-24 15:15:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093943002/20001
4 years, 5 months ago (2016-06-24 15:16:29 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-24 15:32:43 UTC) #8
bsalomon
lgtm
4 years, 5 months ago (2016-06-24 16:19:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093943002/20001
4 years, 5 months ago (2016-06-24 16:20:39 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 16:22:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0a3a7f7303273151f1585b3cf5f6968e3932bfed

Powered by Google App Engine
This is Rietveld 408576698