Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2091823005: Fix vulkan warning in RecordReplaceDrawTest (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@dmTests
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix vulkan warning in RecordReplaceDrawTest Vulkan debug layers complain that when we call readPixels on the texture we are copying unitialized data from the image to a buffer. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2091823005 Committed: https://skia.googlesource.com/skia/+/3fe0aabac1a9ffa926c1de83642371028669831d

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tests/RecordReplaceDrawTest.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
egdaniel
4 years, 6 months ago (2016-06-23 19:13:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091823005/1
4 years, 6 months ago (2016-06-23 19:13:30 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/2091823005/diff/1/tests/RecordReplaceDrawTest.cpp File tests/RecordReplaceDrawTest.cpp (right): https://codereview.chromium.org/2091823005/diff/1/tests/RecordReplaceDrawTest.cpp#newcode126 tests/RecordReplaceDrawTest.cpp:126: texture ?
4 years, 6 months ago (2016-06-23 19:14:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091823005/20001
4 years, 6 months ago (2016-06-23 19:19:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/9261)
4 years, 6 months ago (2016-06-23 19:41:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091823005/20001
4 years, 6 months ago (2016-06-23 21:55:25 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 22:06:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3fe0aabac1a9ffa926c1de83642371028669831d

Powered by Google App Engine
This is Rietveld 408576698