tests/VkWrapTests.cpp - Issue 2093943002: Have gpu createTestingOlyBackendTexture know if it is a render target or not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/VkWrapTests.cpp

Issue 2093943002: Have gpu createTestingOlyBackendTexture know if it is a render target or not (Closed) Base URL: https://skia.googlesource.com/skia.git@moreUnitTests

Patch Set: Have gpu createTestingOlyBackendTexture know if it is a render target or not Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/VkWrapTests.cpp

diff --git a/tests/VkWrapTests.cpp b/tests/VkWrapTests.cpp

index 852597edc07782e8c1ac2e2f89c68115decf203d..fb434a2f26a4a9774af9a25adb443e933c2b4706 100644

--- a/tests/VkWrapTests.cpp

+++ b/tests/VkWrapTests.cpp

@@ -29,7 +29,8 @@ void wrap_tex_test(skiatest::Reporter* reporter, GrContext* context) {

GrVkGpu* gpu = static_cast<GrVkGpu*>(context->getGpu());

- GrBackendObject backendObj = gpu->createTestingOnlyBackendTexture(nullptr, kW, kH, kPixelConfig);

+ GrBackendObject backendObj = gpu->createTestingOnlyBackendTexture(nullptr, kW, kH, kPixelConfig,

+ false);

const GrVkImageInfo* backendTex = reinterpret_cast<const GrVkImageInfo*>(backendObj);

// check basic borrowed creation

@@ -71,7 +72,8 @@ void wrap_tex_test(skiatest::Reporter* reporter, GrContext* context) {

void wrap_rt_test(skiatest::Reporter* reporter, GrContext* context) {

GrVkGpu* gpu = static_cast<GrVkGpu*>(context->getGpu());

- GrBackendObject backendObj = gpu->createTestingOnlyBackendTexture(nullptr, kW, kH, kPixelConfig);

+ GrBackendObject backendObj = gpu->createTestingOnlyBackendTexture(nullptr, kW, kH, kPixelConfig,

+ true);

const GrVkImageInfo* backendTex = reinterpret_cast<const GrVkImageInfo*>(backendObj);

// check basic borrowed creation

@@ -118,7 +120,8 @@ void wrap_rt_test(skiatest::Reporter* reporter, GrContext* context) {

void wrap_trt_test(skiatest::Reporter* reporter, GrContext* context) {

GrVkGpu* gpu = static_cast<GrVkGpu*>(context->getGpu());

- GrBackendObject backendObj = gpu->createTestingOnlyBackendTexture(nullptr, kW, kH, kPixelConfig);

+ GrBackendObject backendObj = gpu->createTestingOnlyBackendTexture(nullptr, kW, kH, kPixelConfig,

+ true);

const GrVkImageInfo* backendTex = reinterpret_cast<const GrVkImageInfo*>(backendObj);

// check basic borrowed creation

« no previous file with comments | « tests/SurfaceTest.cpp ('k') | tools/gpu/GrTest.cpp » ('j') | no next file with comments »