Reland: Make ChromeVox Next a setting in options page

Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has already been attached. Natively, we send the child tree id whenever we see a child tree id within tree data which leads possibly to triggering the entire code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background) needs some modules from Classic like prefs, keymaps, etc to be instantitated and ready.

TBR=dmazzoni@chromium.org
BUG=618094, 618092, 618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/69cea7b2b8e5e2c1522e4d68ffacdbc77e718aa7
Cr-Commit-Position: refs/heads/master@{#401721}

[David Tseng, 2016-06-23 20:04:30]

Description was changed from

==========
Reland:
==========

to

==========
Reland:
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-23 20:10:34]

Description was changed from

==========
Reland:
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The callback can be called when the root automation node has already been
attached.

TBR=dmazzoni@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-23 20:51:30]

Description was changed from

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The callback can be called when the root automation node has already been
attached.

TBR=dmazzoni@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-23 20:57:17]

Description was changed from

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org
BUG=618094, 618092, 618090

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-23 20:57:23]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-06-23 20:57:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093753002/1

[commit-bot: I haz the power, 2016-06-23 21:25:24]

Description was changed from

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org
BUG=618094, 618092, 618090

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org
BUG=618094, 618092, 618090

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-23 21:25:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-23 21:28:00]

Description was changed from

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org
BUG=618094, 618092, 618090

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland: Make ChromeVox Next a setting in options page

Original cl:
https://codereview.chromium.org/2079073002/

The flakeyness seen in the tests is fixed by the change to
automation_custom_bindings.js.

The child tree id callback can be called when the root automation node has
already been attached. Natively, we send the child tree id whenever we see a
child tree id within tree data which leads possibly to triggering the entire
code path multiple times for the same tree.

The reason why this flakeyness appears now is because
Background depends on cvox.ChromeVoxBackground
explicitly via goog.require. This is correct as ChromeVox Next (Background)
needs some modules from Classic like prefs, keymaps, etc to be instantitated and
ready.

TBR=dmazzoni@chromium.org
BUG=618094, 618092, 618090

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/69cea7b2b8e5e2c1522e4d68ffacdbc77e718aa7
Cr-Commit-Position: refs/heads/master@{#401721}
==========

[commit-bot: I haz the power, 2016-06-23 21:28:01]

Patchset 1 (id:??) landed as
https://crrev.com/69cea7b2b8e5e2c1522e4d68ffacdbc77e718aa7
Cr-Commit-Position: refs/heads/master@{#401721}