Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: chrome/renderer/resources/extensions/automation_custom_bindings.js

Issue 2093753002: Reland: Make ChromeVox Next a setting in options page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/automation_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/automation_custom_bindings.js b/chrome/renderer/resources/extensions/automation_custom_bindings.js
index 7321710fb7d5a08761de9e5dca8a84438758b75d..f33715e80a08c2f938c34874894651b7a4d8eacc 100644
--- a/chrome/renderer/resources/extensions/automation_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/automation_custom_bindings.js
@@ -210,6 +210,10 @@ automationInternal.onChildTreeID.addListener(function(treeID,
var subroot = AutomationRootNode.get(childTreeID);
if (!subroot) {
automationUtil.storeTreeCallback(childTreeID, function(root) {
+ // Return early if the root has already been attached.
+ if (root.parent)
+ return;
+
privates(root).impl.setHostNode(node);
if (root.docLoaded)
@@ -333,4 +337,3 @@ forEach(schema, function(k, v) {
});
exports.$set('binding', binding);
-
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698