chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js - Issue 2093753002: Reland: Make ChromeVox Next a setting in options page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

Issue 2093753002: Reland: Make ChromeVox Next a setting in options page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

index d084d5bc12fd3209d86ab37eff77dfc7d0a55659..000462fae0ec2537cb5b89818711ef42f277bddd 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

@@ -73,7 +73,9 @@ cvox.TabsApiHandler.prototype = {

cvox.NavBraille.fromText(this.msg_('chrome_tab_created')));

}

cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.OBJECT_OPEN);

- this.refreshAutomationHandler_(tab.id);

+ if (tab) {

+ this.refreshAutomationHandler_(tab.id);

+ }

/**

@@ -226,7 +228,7 @@ cvox.TabsApiHandler.prototype = {

if (!tab)

return;

- global.backgroundObj.refreshMode(tab);

+ ChromeVoxState.instance.setCurrentRange(cursors.Range.fromNode(tab));

});