Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2093553004: Reduce SpdyHeaderBlock copies with move semantics in shared code. (Closed)

Created:
4 years, 6 months ago by Bence
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce SpdyHeaderBlock copies with move semantics in shared code. In order to reduce SpdyHeaderBlock copies, * take SpdyHeaderBlock by value instead of const ref, * std::move SpdyHeaderBlock at call sites if possible. This lands server side change 125673600 by bnc. BUG=621905 Committed: https://crrev.com/2dc1cc43f5fe0e63c0e632008f4d9a8f122f5f6d Cr-Commit-Position: refs/heads/master@{#401749}

Patch Set 1 #

Patch Set 2 : Remove non-shared files (into a separate CL). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -31 lines) Patch
M net/quic/quic_chromium_client_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_stream.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_spdy_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 6 months ago (2016-06-23 17:22:01 UTC) #3
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-06-23 18:18:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093553004/20001
4 years, 6 months ago (2016-06-23 23:02:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 23:08:55 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 23:10:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2dc1cc43f5fe0e63c0e632008f4d9a8f122f5f6d
Cr-Commit-Position: refs/heads/master@{#401749}

Powered by Google App Engine
This is Rietveld 408576698