net/quic/quic_spdy_stream.h - Issue 2093553004: Reduce SpdyHeaderBlock copies with move semantics in shared code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_spdy_stream.h

Issue 2093553004: Reduce SpdyHeaderBlock copies with move semantics in shared code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove non-shared files (into a separate CL). Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_spdy_stream.h

diff --git a/net/quic/quic_spdy_stream.h b/net/quic/quic_spdy_stream.h

index 01cb647ba8ca86eb147a9dc39d85e021bb6493fd..c566165f67d2570e5308693fe020116dee1e2630 100644

--- a/net/quic/quic_spdy_stream.h

+++ b/net/quic/quic_spdy_stream.h

@@ -120,7 +120,7 @@ class NET_EXPORT_PRIVATE QuicSpdyStream : public ReliableQuicStream {

// Writes the headers contained in |header_block| to the dedicated

// headers stream.

- virtual size_t WriteHeaders(const SpdyHeaderBlock& header_block,

+ virtual size_t WriteHeaders(SpdyHeaderBlock header_block,

bool fin,

QuicAckListenerInterface* ack_notifier_delegate);

@@ -131,7 +131,7 @@ class NET_EXPORT_PRIVATE QuicSpdyStream : public ReliableQuicStream {

// Writes the trailers contained in |trailer_block| to the dedicated

// headers stream. Trailers will always have the FIN set.

- virtual size_t WriteTrailers(const SpdyHeaderBlock& trailer_block,

+ virtual size_t WriteTrailers(SpdyHeaderBlock trailer_block,

QuicAckListenerInterface* ack_notifier_delegate);

// Marks |bytes_consumed| of the headers data as consumed.

« no previous file with comments | « net/quic/quic_chromium_client_stream.cc ('k') | net/quic/quic_spdy_stream.cc » ('j') | no next file with comments »