Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: net/quic/quic_spdy_stream_test.cc

Issue 2093553004: Reduce SpdyHeaderBlock copies with move semantics in shared code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove non-shared files (into a separate CL). Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_stream.cc ('k') | net/tools/quic/quic_simple_server_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_spdy_stream_test.cc
diff --git a/net/quic/quic_spdy_stream_test.cc b/net/quic/quic_spdy_stream_test.cc
index 7a1b8540f92a1628f93fe68c4afbbe259aa74a63..a554181dbbc2b9875162ccc86cf7fa8655ecc92a 100644
--- a/net/quic/quic_spdy_stream_test.cc
+++ b/net/quic/quic_spdy_stream_test.cc
@@ -5,6 +5,7 @@
#include "net/quic/quic_spdy_stream.h"
#include <memory>
+#include <utility>
#include "base/strings/string_number_conversions.h"
#include "net/quic/quic_connection.h"
@@ -894,7 +895,7 @@ TEST_P(QuicSpdyStreamTest, WritingTrailersSendsAFin) {
trailers["trailer key"] = "trailer value";
EXPECT_CALL(*session_, WriteHeaders(_, _,
/*fin=*/true, _, _));
- stream_->WriteTrailers(trailers, nullptr);
+ stream_->WriteTrailers(std::move(trailers), nullptr);
EXPECT_TRUE(stream_->fin_sent());
}
@@ -922,7 +923,7 @@ TEST_P(QuicSpdyStreamTest, WritingTrailersFinalOffset) {
trailers_with_offset[kFinalOffsetHeaderKey] = base::IntToString(kBodySize);
EXPECT_CALL(*session_, WriteHeaders(_, testing::Eq(trailers_with_offset),
/*fin=*/true, _, _));
- stream_->WriteTrailers(trailers, nullptr);
+ stream_->WriteTrailers(std::move(trailers), nullptr);
}
TEST_P(QuicSpdyStreamTest, WritingTrailersClosesWriteSide) {
« no previous file with comments | « net/quic/quic_spdy_stream.cc ('k') | net/tools/quic/quic_simple_server_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698