Issue 209353014: Fix for crash on large image blur sigma values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209353014: Fix for crash on large image blur sigma values. (Closed)

Created:
6 years, 9 months ago by Stephen White

Modified:
6 years, 9 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix for crash on large image blur sigma values. This was crashing on the GPU path, due to a failed texture allocation. The belt-and-suspenders fix is to: 1) Limit the GPU path to only allocate up to maxTextureSize. 2) Limit both the raster and GPU paths to reasonable blur sizes (box blur kernel size of 1000, resulting in a sigma limit of 532). R=bsalomon@google.com BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13923

Patch Set 1 #

Patch Set 2 : Remove spurious #include. #

Patch Set 3 : Tweak #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -3 lines)			Patch
M	src/effects/SkBlurImageFilter.cpp	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/effects/SkGpuBlurUtils.cpp	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View		2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Committed patchset #3 manually as r13923 (presubmit successful).

6 years, 9 months ago (2014-03-24 20:51:03 UTC) #3

robertphillips

I don't know if these old (never-landed) patches are relevant: https://codereview.chromium.org/195113002/ Fix for 32767 blur ...

6 years, 9 months ago (2014-03-25 12:16:40 UTC) #4

Stephen White

6 years, 9 months ago (2014-03-25 12:22:16 UTC) #5

Message was sent while issue was closed.

On 2014/03/25 12:16:40, robertphillips wrote:
> I don't know if these old (never-landed) patches are relevant:
> https://codereview.chromium.org/195113002/ Fix for 32767 blur crash
> https://codereview.chromium.org/67263002/  Add additional case to bigblurs GM

Thanks for the ref! However, those are for mask (shadow) blurs, not RGBA blurs.

Expand Messages | Collapse Messages