Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2093373004: [ImportantStorage] Clear button string update and lint fixes. (Closed)

Created:
4 years, 5 months ago by dmurph
Modified:
4 years, 5 months ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ImportantStorage] Clear button string update and lint fixes. BUG=623259 Committed: https://crrev.com/7b0de477f2d1e4b304d664f9925324a1f569369a Cr-Commit-Position: refs/heads/master@{#402323}

Patch Set 1 #

Total comments: 2

Patch Set 2 : disabled accessibility for favicon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/android/java/res/layout/confirm_important_sites_list_row.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/manage_space_activity.xml View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ConfirmImportantSitesDialogFragment.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dmurph
Hello! String file update and lint fixes here.
4 years, 5 months ago (2016-06-27 19:15:52 UTC) #2
Theresa
https://codereview.chromium.org/2093373004/diff/1/chrome/android/java/res/layout/confirm_important_sites_list_row.xml File chrome/android/java/res/layout/confirm_important_sites_list_row.xml (right): https://codereview.chromium.org/2093373004/diff/1/chrome/android/java/res/layout/confirm_important_sites_list_row.xml#newcode27 chrome/android/java/res/layout/confirm_important_sites_list_row.xml:27: <ImageView Can the image view gain focus when TalkBack ...
4 years, 5 months ago (2016-06-27 20:11:17 UTC) #3
dmurph
https://codereview.chromium.org/2093373004/diff/1/chrome/android/java/res/layout/confirm_important_sites_list_row.xml File chrome/android/java/res/layout/confirm_important_sites_list_row.xml (right): https://codereview.chromium.org/2093373004/diff/1/chrome/android/java/res/layout/confirm_important_sites_list_row.xml#newcode27 chrome/android/java/res/layout/confirm_important_sites_list_row.xml:27: <ImageView On 2016/06/27 at 20:11:17, Theresa Wellington wrote: > ...
4 years, 5 months ago (2016-06-27 21:28:45 UTC) #4
Theresa
lgtm
4 years, 5 months ago (2016-06-27 21:31:09 UTC) #5
Ted C
lgtm
4 years, 5 months ago (2016-06-27 21:36:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093373004/20001
4 years, 5 months ago (2016-06-27 22:55:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 23:04:34 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 23:06:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b0de477f2d1e4b304d664f9925324a1f569369a
Cr-Commit-Position: refs/heads/master@{#402323}

Powered by Google App Engine
This is Rietveld 408576698