Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2093323002:
Allow Chrome's Non-Client Area To Be Scaled on DPI Changes (Closed)
DescriptionAllow Chrome's Non-Client Area To Be Scaled on DPI Changes
EnableChildWindowDpiMessage enables non-client area updates on DPI changes,
providing DPI appropriate caption buttons as well as the system context menu.
Menubars currently don't appear to scale correctly, but Chrome doesn't use
them, so we're good to go here.
BUG=426656
Committed: https://crrev.com/a66e015b5a967941a08803b58c50f7f4927a9de8
Cr-Commit-Position: refs/heads/master@{#402350}
Patch Set 1 #
Total comments: 6
Patch Set 2 : CR Feedback scottmg@ #Patch Set 3 : Adjust Upstream Patchset #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 27 (12 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robliao@chromium.org changed reviewers: + scottmg@chromium.org
scottmg: Please review the Windows code in this change. Thanks!
https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.cc File ui/gfx/win/window_impl.cc (right): https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.... ui/gfx/win/window_impl.cc:220: // is fired. Any semi-documentation you can link here? https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.... ui/gfx/win/window_impl.cc:222: HMODULE user32 = GetModuleHandle(L"user32"); Other instances seem to include ".dll". https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.... ui/gfx/win/window_impl.cc:223: if (user32) { Don't think you need to check user32 here, just inline into GetProcAddress(); we just called CreateWindowEx() above.
https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.cc File ui/gfx/win/window_impl.cc (right): https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.... ui/gfx/win/window_impl.cc:220: // is fired. On 2016/06/27 19:26:35, scottmg wrote: > Any semi-documentation you can link here? Unfortunately not that I can find. This is pretty leading edge. https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.... ui/gfx/win/window_impl.cc:222: HMODULE user32 = GetModuleHandle(L"user32"); On 2016/06/27 19:26:35, scottmg wrote: > Other instances seem to include ".dll". Done. https://codereview.chromium.org/2093323002/diff/20001/ui/gfx/win/window_impl.... ui/gfx/win/window_impl.cc:223: if (user32) { On 2016/06/27 19:26:35, scottmg wrote: > Don't think you need to check user32 here, just inline into GetProcAddress(); we > just called CreateWindowEx() above. Done. Yup, we seem to do it in other places indeed. Just wanted to guard against other faliures that GetModuleHandle would encounter, but then we would be in trouble in other places anyways.
lgtm
robliao@chromium.org changed reviewers: + sky@chromium.org
sky: Please review this changelist. Thanks!
LGTM
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2093323002/#ps60001 (title: "Adjust Upstream Patchset")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Allow Chrome's Non-Client Area To Be Scaled on DPI Changes EnableChildWindowDpiMessage enables non-client area updates on DPI changes, providing DPI appropriate caption buttons as well as the system context menu. Menubars currently don't appear to scale correctly, but Chrome doesn't use them, so we're good to go here. BUG=426656 ========== to ========== Allow Chrome's Non-Client Area To Be Scaled on DPI Changes EnableChildWindowDpiMessage enables non-client area updates on DPI changes, providing DPI appropriate caption buttons as well as the system context menu. Menubars currently don't appear to scale correctly, but Chrome doesn't use them, so we're good to go here. BUG=426656 Committed: https://crrev.com/a66e015b5a967941a08803b58c50f7f4927a9de8 Cr-Commit-Position: refs/heads/master@{#402350} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a66e015b5a967941a08803b58c50f7f4927a9de8 Cr-Commit-Position: refs/heads/master@{#402350} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
