Add Plumbing for WM_DPICHANGED

Add Plumbing for WM_DPICHANGED

Once Per-Monitor DPI is enabled for Chrome, WM_DPICHANGED will be fired by the
Windows manager to let Chrome now the DPI for its HWND has changed and suggest
a new size and location for the Chrome Window based off of the new DPI.

BUG=426656
Committed: https://crrev.com/d71e32d341aeff06994f268bda7b110fb2df48be
Cr-Commit-Position: refs/heads/master@{#402353}

[robliao, 2016-06-25 01:27:29]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-25 01:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 02:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-25 02:38:16]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-06-27 17:03:26]

robliao@chromium.org changed reviewers:
+ sky@chromium.org

[robliao, 2016-06-27 17:03:26]

sky: Please review this changelist. Thanks!

[sky, 2016-06-27 19:09:22]

Only a question about the DCHECK.

https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
ui/views/win/hwnd_message_handler.cc:1403: DCHECK_EQ(LOWORD(w_param),
HIWORD(w_param));
Is this DCHECK really worthwhile? Presumably folks can still run on non-square
scales and would then hit this, right? What good would the DCHECK do?

[robliao, 2016-06-27 19:40:34]

https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
ui/views/win/hwnd_message_handler.cc:1403: DCHECK_EQ(LOWORD(w_param),
HIWORD(w_param));
On 2016/06/27 19:09:22, sky wrote:
> Is this DCHECK really worthwhile? Presumably folks can still run on non-square
> scales and would then hit this, right? What good would the DCHECK do?

The DCHECK is only worthwhile to the extent that this is one of the leading
edges of accepting scale factor information in Chrome. The other is when we
construct the displays, which would also trigger.

I can remove it if you want.

[sky, 2016-06-27 20:03:43]

WDYT of a NOTIMPLEMENTED?

On Mon, Jun 27, 2016 at 12:40 PM,  <robliao@chromium.org> wrote:
>
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
> File ui/views/win/hwnd_message_handler.cc (right):
>
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
> ui/views/win/hwnd_message_handler.cc:1403: DCHECK_EQ(LOWORD(w_param),
> HIWORD(w_param));
> On 2016/06/27 19:09:22, sky wrote:
>> Is this DCHECK really worthwhile? Presumably folks can still run on
> non-square
>> scales and would then hit this, right? What good would the DCHECK do?
>
> The DCHECK is only worthwhile to the extent that this is one of the
> leading edges of accepting scale factor information in Chrome. The other
> is when we construct the displays, which would also trigger.
>
> I can remove it if you want.
>
> https://codereview.chromium.org/2093993003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[robliao, 2016-06-27 20:22:43]

On 2016/06/27 20:03:43, sky wrote:
> WDYT of a NOTIMPLEMENTED?
> 
> On Mon, Jun 27, 2016 at 12:40 PM,  <mailto:robliao@chromium.org> wrote:
> >
> >
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
> > File ui/views/win/hwnd_message_handler.cc (right):
> >
> >
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
> > ui/views/win/hwnd_message_handler.cc:1403: DCHECK_EQ(LOWORD(w_param),
> > HIWORD(w_param));
> > On 2016/06/27 19:09:22, sky wrote:
> >> Is this DCHECK really worthwhile? Presumably folks can still run on
> > non-square
> >> scales and would then hit this, right? What good would the DCHECK do?
> >
> > The DCHECK is only worthwhile to the extent that this is one of the
> > leading edges of accepting scale factor information in Chrome. The other
> > is when we construct the displays, which would also trigger.
> >
> > I can remove it if you want.
> >
> > https://codereview.chromium.org/2093993003/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

An if-check then a NOTIMPLEMENTED()? Not sure if it's any better than a DCHECK.

[sky, 2016-06-27 20:47:22]

Sorry, I should have explained my rationale.
The reason I don't like the DCHECK is that if the scale isn't square
DCHECK is fatal (at least in debug and release with dchecks enabled),
but AFAICT we will continue on just fine. For this reason DCHECK isn't
right. NOTIMPLEMENTED logs that we don't really support this config,
but continues on, which I think is what you want to conveh. Make
sense?

  -Scott

On Mon, Jun 27, 2016 at 1:22 PM,  <robliao@chromium.org> wrote:
> On 2016/06/27 20:03:43, sky wrote:
>> WDYT of a NOTIMPLEMENTED?
>>
>> On Mon, Jun 27, 2016 at 12:40 PM, <mailto:robliao@chromium.org> wrote:
>> >
>> >
>>
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
>> > File ui/views/win/hwnd_message_handler.cc (right):
>> >
>> >
>>
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
>> > ui/views/win/hwnd_message_handler.cc:1403: DCHECK_EQ(LOWORD(w_param),
>> > HIWORD(w_param));
>> > On 2016/06/27 19:09:22, sky wrote:
>> >> Is this DCHECK really worthwhile? Presumably folks can still run on
>> > non-square
>> >> scales and would then hit this, right? What good would the DCHECK do?
>> >
>> > The DCHECK is only worthwhile to the extent that this is one of the
>> > leading edges of accepting scale factor information in Chrome. The other
>> > is when we construct the displays, which would also trigger.
>> >
>> > I can remove it if you want.
>> >
>> > https://codereview.chromium.org/2093993003/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Chromium-reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
> email
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> An if-check then a NOTIMPLEMENTED()? Not sure if it's any better than a
> DCHECK.
>
> https://codereview.chromium.org/2093993003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[robliao, 2016-06-27 21:39:23]

On 2016/06/27 20:47:22, sky wrote:
> Sorry, I should have explained my rationale.
> The reason I don't like the DCHECK is that if the scale isn't square
> DCHECK is fatal (at least in debug and release with dchecks enabled),
> but AFAICT we will continue on just fine. For this reason DCHECK isn't
> right. NOTIMPLEMENTED logs that we don't really support this config,
> but continues on, which I think is what you want to conveh. Make
> sense?
> 
>   -Scott
> 
> On Mon, Jun 27, 2016 at 1:22 PM,  <mailto:robliao@chromium.org> wrote:
> > On 2016/06/27 20:03:43, sky wrote:
> >> WDYT of a NOTIMPLEMENTED?
> >>
> >> On Mon, Jun 27, 2016 at 12:40 PM, <mailto:robliao@chromium.org> wrote:
> >> >
> >> >
> >>
> >
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
> >> > File ui/views/win/hwnd_message_handler.cc (right):
> >> >
> >> >
> >>
> >
>
https://codereview.chromium.org/2093993003/diff/1/ui/views/win/hwnd_message_h...
> >> > ui/views/win/hwnd_message_handler.cc:1403: DCHECK_EQ(LOWORD(w_param),
> >> > HIWORD(w_param));
> >> > On 2016/06/27 19:09:22, sky wrote:
> >> >> Is this DCHECK really worthwhile? Presumably folks can still run on
> >> > non-square
> >> >> scales and would then hit this, right? What good would the DCHECK do?
> >> >
> >> > The DCHECK is only worthwhile to the extent that this is one of the
> >> > leading edges of accepting scale factor information in Chrome. The other
> >> > is when we construct the displays, which would also trigger.
> >> >
> >> > I can remove it if you want.
> >> >
> >> > https://codereview.chromium.org/2093993003/
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "Chromium-reviews" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an
> > email
> >> to mailto:chromium-reviews+unsubscribe@chromium.org.
> >>
> >
> > An if-check then a NOTIMPLEMENTED()? Not sure if it's any better than a
> > DCHECK.
> >
> > https://codereview.chromium.org/2093993003/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

>Sorry, I should have explained my rationale.
>The reason I don't like the DCHECK is that if the scale isn't square
>DCHECK is fatal (at least in debug and release with dchecks enabled),
>but AFAICT we will continue on just fine. For this reason DCHECK isn't
>right. NOTIMPLEMENTED logs that we don't really support this config,
>but continues on, which I think is what you want to conveh. Make
>sense?
Gotcha. That works for me. I've updated the check.

[sky, 2016-06-27 21:58:05]

LGTM

[robliao, 2016-06-27 22:00:44]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 22:03:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2016-06-27 23:14:29]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2016-06-27 23:14:39]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 23:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 00:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 00:17:39]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-06-28 00:53:53]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-06-28 00:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 01:00:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 01:02:44]

Description was changed from

==========
Add Plumbing for WM_DPICHANGED

Once Per-Monitor DPI is enabled for Chrome, WM_DPICHANGED will be fired by the
Windows manager to let Chrome now the DPI for its HWND has changed and suggest
a new size and location for the Chrome Window based off of the new DPI.

BUG=426656
==========

to

==========
Add Plumbing for WM_DPICHANGED

Once Per-Monitor DPI is enabled for Chrome, WM_DPICHANGED will be fired by the
Windows manager to let Chrome now the DPI for its HWND has changed and suggest
a new size and location for the Chrome Window based off of the new DPI.

BUG=426656

Committed: https://crrev.com/d71e32d341aeff06994f268bda7b110fb2df48be
Cr-Commit-Position: refs/heads/master@{#402353}
==========

[commit-bot: I haz the power, 2016-06-28 01:02:45]

Patchset 2 (id:??) landed as
https://crrev.com/d71e32d341aeff06994f268bda7b110fb2df48be
Cr-Commit-Position: refs/heads/master@{#402353}