Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2093003002: MacViews: Fix BridgedNativeWidget.* tests which fail on OSX 10.9. (Closed)

Created:
4 years, 6 months ago by karandeepb
Modified:
4 years, 5 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix BridgedNativeWidget.* tests which fail on OSX 10.9. This CL fixes the following views_unittests which fail on OSX 10.9- -BridgedNativeWidgetTest.TextInput_DeleteCommands -BridgedNativeWidgetTest.TextInput_MoveEditingCommands The reason for these failures is that an NSTextView on 10.9 behaves weirdly if initialized with an NSZeroRect as its frame rectangle. Changing the frame rectangle to a larger one fixes the tests. BUG=621734, 607403 Committed: https://crrev.com/1373d81bf918bd38991cb3bd790834fe53189632 Cr-Commit-Position: refs/heads/master@{#402394}

Patch Set 1 #

Patch Set 2 : Rebase. Enable tests on 10.9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 3 chunks +4 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
karandeepb
PTAL Trent.
4 years, 6 months ago (2016-06-24 08:14:06 UTC) #5
karandeepb
PTAL Trent. Have enabled the fixed tests.
4 years, 5 months ago (2016-06-27 07:18:20 UTC) #6
tapted
lgtm - thanks!
4 years, 5 months ago (2016-06-28 03:34:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093003002/40001
4 years, 5 months ago (2016-06-28 03:36:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-06-28 03:43:23 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 03:45:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1373d81bf918bd38991cb3bd790834fe53189632
Cr-Commit-Position: refs/heads/master@{#402394}

Powered by Google App Engine
This is Rietveld 408576698