Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: ui/views/cocoa/bridged_native_widget_unittest.mm

Issue 2093003002: MacViews: Fix BridgedNativeWidget.* tests which fail on OSX 10.9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Enable tests on 10.9 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/cocoa/bridged_native_widget_unittest.mm
diff --git a/ui/views/cocoa/bridged_native_widget_unittest.mm b/ui/views/cocoa/bridged_native_widget_unittest.mm
index 61b7f498124920fdfb0e6de59f7b51db3d2f4ee0..416cfbcc478c4ef155128b73b34f145d40e4d4a0 100644
--- a/ui/views/cocoa/bridged_native_widget_unittest.mm
+++ b/ui/views/cocoa/bridged_native_widget_unittest.mm
@@ -361,8 +361,10 @@ void BridgedNativeWidgetTest::InstallTextField(
[ns_view_ setTextInputClient:textfield];
- // Initialize the dummy text view.
- dummy_text_view_.reset([[NSTextView alloc] initWithFrame:NSZeroRect]);
+ // Initialize the dummy text view. Initializing this with NSZeroRect causes
+ // weird NSTextView behavior on OSX 10.9.
+ dummy_text_view_.reset(
+ [[NSTextView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100)]);
[dummy_text_view_ setString:SysUTF16ToNSString(text)];
}
@@ -1001,9 +1003,6 @@ TEST_F(BridgedNativeWidgetTest, TextInput_DeleteToEndOfParagraph) {
// Test move commands against expectations set by |dummy_text_view_|.
TEST_F(BridgedNativeWidgetTest, TextInput_MoveEditingCommands) {
- // Broken on 10.9. http://crbug.com/621734.
- if (base::mac::IsOSMavericks())
- return;
TestEditingCommands(kMoveActions);
}
@@ -1017,9 +1016,6 @@ TEST_F(BridgedNativeWidgetTest,
// Test delete commands against expectations set by |dummy_text_view_|.
TEST_F(BridgedNativeWidgetTest, TextInput_DeleteCommands) {
- // Broken on 10.9. http://crbug.com/621734.
- if (base::mac::IsOSMavericks())
- return;
TestEditingCommands(kDeleteActions);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698