[MD Settings] Add a menu option to clear a cached credit card.

[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/673b2b68a0b10d5f23464569979110a93b5dcb7f
Cr-Commit-Position: refs/heads/master@{#402336}

[hcarmona, 2016-06-25 00:25:54]

Description was changed from

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
==========

to

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-06-25 00:27:34]

Description was changed from

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-06-25 00:27:34]

hcarmona@chromium.org changed reviewers:
+ tommycli@chromium.org

[hcarmona, 2016-06-25 00:28:01]

PTAL, thanks!

[tommycli, 2016-06-25 00:36:01]

lgtm sans nit:

https://codereview.chromium.org/2092323002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2092323002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:283:
/** @type {string} */(creditCard.guid));
These typecasts seem interesting. Are these variables actually Numbers or
something?

[hcarmona, 2016-06-27 22:22:32]

https://codereview.chromium.org/2092323002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2092323002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:283:
/** @type {string} */(creditCard.guid));
On 2016/06/25 00:36:01, tommycli wrote:
> These typecasts seem interesting. Are these variables actually Numbers or
> something?

Tried something else. WDYT?

[tommycli, 2016-06-27 22:31:28]

LGTM, much improved, one nit:

https://codereview.chromium.org/2092323002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2092323002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:251:
// GUID identifies an address: can't delete one if you don't know which
The assert is pretty self explanatory. No need for the comments on them IMO.

[hcarmona, 2016-06-27 22:42:13]

Removed unneeded comments, committing. Thanks!

https://codereview.chromium.org/2092323002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2092323002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:251:
// GUID identifies an address: can't delete one if you don't know which
On 2016/06/27 22:31:28, tommycli wrote:
> The assert is pretty self explanatory. No need for the comments on them IMO.

👍

[hcarmona, 2016-06-27 22:42:22]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-06-27 22:42:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2092323002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-06-27 22:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 00:12:49]

Description was changed from

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-28 00:12:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-28 00:14:46]

Description was changed from

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Add a menu option to clear a cached credit card.

This only applies to credit cards that were imported from Google
Payments and saved locally. Does not delete the credit card info from
the Google Payments servers.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/673b2b68a0b10d5f23464569979110a93b5dcb7f
Cr-Commit-Position: refs/heads/master@{#402336}
==========

[commit-bot: I haz the power, 2016-06-28 00:14:47]

Patchset 3 (id:??) landed as
https://crrev.com/673b2b68a0b10d5f23464569979110a93b5dcb7f
Cr-Commit-Position: refs/heads/master@{#402336}