Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7394)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Issue 2092323002: [MD Settings] Add a menu option to clear a cached credit card. (Closed) Base URL: hcarmona0.lax.corp.google.com:/usr/local/google/home/hcarmona/src@cc-clear-cache.gitbr
Patch Set: nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
index a932c48b5f2e4a97d54ac7f2f501f5f40e18565a..174b509f9cb855fb9b031261d522a5f06af7096e 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
@@ -116,7 +116,7 @@ AutofillManager.prototype = {
*/
getAddressList: assertNotReached,
- /** @param {!AutofillManager.AddressEntry} address The address to remove. */
+ /** @param {string} guid The guid of the address to remove. */
removeAddress: assertNotReached,
/**
@@ -137,12 +137,12 @@ AutofillManager.prototype = {
*/
getCreditCardList: assertNotReached,
- /**
- * @param {!AutofillManager.CreditCardEntry} creditCard The credit card to
- * remove.
- */
+ /** @param {string} guid The GUID of the credit card to remove. */
removeCreditCard: assertNotReached,
+ /** @param {string} guid The GUID to credit card to remove from the cache. */
+ clearCachedCreditCard: assertNotReached,
+
/**
* Saves the given credit card.
* @param {!AutofillManager.CreditCardEntry} creditCard
@@ -247,8 +247,9 @@ AutofillManagerImpl.prototype = {
},
/** @override */
- removeAddress: function(address) {
- chrome.autofillPrivate.removeEntry(/** @type {string} */(address.guid));
+ removeAddress: function(guid) {
+ assert(guid);
+ chrome.autofillPrivate.removeEntry(guid);
},
/** @override */
@@ -267,8 +268,15 @@ AutofillManagerImpl.prototype = {
},
/** @override */
- removeCreditCard: function(creditCard) {
- chrome.autofillPrivate.removeEntry(/** @type {string} */(creditCard.guid));
+ removeCreditCard: function(guid) {
+ assert(guid);
+ chrome.autofillPrivate.removeEntry(guid);
+ },
+
+ /** @override */
+ clearCachedCreditCard: function(guid) {
+ assert(guid);
+ chrome.autofillPrivate.maskCreditCard(guid);
},
/** @override */
@@ -326,6 +334,7 @@ Polymer({
},
listeners: {
+ 'clear-credit-card': 'clearCreditCard_',
'remove-address': 'removeAddress_',
'remove-credit-card': 'removeCreditCard_',
'remove-password-exception': 'removePasswordException_',
@@ -422,7 +431,7 @@ Polymer({
* @private
*/
removeAddress_: function(event) {
- this.autofillManager_.removeAddress(event.detail);
+ this.autofillManager_.removeAddress(event.detail.guid);
},
/**
@@ -431,7 +440,16 @@ Polymer({
* @private
*/
removeCreditCard_: function(event) {
- this.autofillManager_.removeCreditCard(event.detail);
+ this.autofillManager_.removeCreditCard(event.detail.guid);
+ },
+
+ /**
+ * Listens for the clear-credit-card event, and calls the private API.
+ * @param {!Event} event
+ * @private
+ */
+ clearCreditCard_: function(event) {
+ this.autofillManager_.clearCachedCreditCard(event.detail.guid);
},
/**

Powered by Google App Engine
This is Rietveld 408576698